Skip to content

Tests: fix false positive#925

Merged
CertainLach merged 3 commits into
developfrom
tests/fix-false-positive
Apr 21, 2023
Merged

Tests: fix false positive#925
CertainLach merged 3 commits into
developfrom
tests/fix-false-positive

Conversation

@Maksandre

Copy link
Copy Markdown
Contributor

No description provided.

Tests should try trasferFrom token owner

@CertainLach CertainLach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я так понял, это не обязательно должно в этот релиз попасть, т.к тут нет семантических изменений?

Comment thread tests/src/approve.test.ts Outdated
@CertainLach

Copy link
Copy Markdown
Member

Если на релизе тесты обвалятся как-то ещё, кроме проблемы с сетью в одном из workflow - то возьму в этот, иначе приму только в develop

@CertainLach CertainLach merged commit 4da53d3 into develop Apr 21, 2023
@CertainLach CertainLach deleted the tests/fix-false-positive branch April 21, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants