fix: fixing color of buttons #5179
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/nft/components/bag/BagHeader.tsx
Outdated
|
|
||
| :hover { | ||
| color: ${({ theme }) => theme.accentActive}; | ||
| } |
There was a problem hiding this comment.
we had a random blue hoverstate
| @@ -8,7 +8,8 @@ export const container = style([ | |||
| paddingTop: '4', | |||
| }), | |||
| { | |||
| width: '300px', | |||
| width: '308px', | |||
| paddingRight: '8px', | |||
There was a problem hiding this comment.
the shadow on the right slider overlaps the adjacent div, which creates a line to the right that looks strange(light mode only). This maintains the original dimensions while solving that issue
| @@ -41,7 +41,6 @@ export const commonButtonStyles = style([ | |||
| sprinkles({ | |||
| borderRadius: '12', | |||
| transition: '250', | |||
| boxShadow: { hover: 'elevation' }, | |||
There was a problem hiding this comment.
common button styles has a boxShadow. Not a heavily used style, but we removed boxShadows from buttons
aballerr
requested review from
a team and
lynnshaoyu
and removed request for
a team
| @@ -37,7 +37,7 @@ export const FilterButton = ({ | |||
| width={isMobile ? '44' : 'auto'} | |||
| height="44" | |||
| whiteSpace="nowrap" | |||
| color="textPrimary" | |||
| color="white" | |||
There was a problem hiding this comment.
are we sure we want to hardcode this tow hite?
There was a problem hiding this comment.
this is a merge conflict, i changed this upstream
There was a problem hiding this comment.
This is what it looks like with textPrimary
| borderRadius: '4px', | ||
| border: 'none', | ||
| boxShadow: `${theme.shallowShadow.slice(0, -1)}`, | ||
| boxShadow: colorsDark.shallowShadow.slice(0, -1), |
There was a problem hiding this comment.
Why aren't we pulling this from theme anymore?
There was a problem hiding this comment.
theme has a different shadow color. I couldn't find this exact shadow defined anywhere but in darktheme.
| @@ -372,7 +372,7 @@ export const AssetPriceDetails = ({ asset, collection }: AssetPriceDetailsProps) | |||
| } | |||
| }} | |||
| > | |||
| <SubHeader lineHeight={'20px'}> | |||
| <SubHeader color="white" lineHeight={'20px'}> | |||
There was a problem hiding this comment.
primary isn't white in light theme
There was a problem hiding this comment.
@aballerr could you sync with yushin on this? Apparently they defined a button-label in the design system that reflects what the text colors should be for light and dark.
There was a problem hiding this comment.
This is what buy now currently looks like and this is what buttons on our site look like. I'm not really sure what I need to sync on to be honest
|
|
||
| @media screen and (max-width: ${MOBILE_MEDIA_BREAKPOINT}) { | ||
| padding-left: 16px; | ||
| } |
There was a problem hiding this comment.
https://uniswaplabs.atlassian.net/browse/WEB-2159
https://uniswaplabs.atlassian.net/browse/WEB-2104
Fixing a bunch of button text colors on light mode
Also fixing royalty fees