Skip to content

feat: Add BNB Network support #6036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 62 commits into from
Mar 15, 2023
Merged

feat: Add BNB Network support #6036

merged 62 commits into from
Mar 15, 2023

Conversation

JFrankfurt
Copy link
Contributor

@JFrankfurt JFrankfurt commented Feb 27, 2023

Shout out to @ilyamk for doing most of the work here.

@vercel
Copy link

vercel bot commented Feb 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
interface ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 9:31PM (UTC)

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 27, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f4571e7
Status:🚫  Build failed.

View logs

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (ee2dc1e) 14.57% compared to head (b782496) 14.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6036      +/-   ##
==========================================
- Coverage   14.57%   14.55%   -0.02%     
==========================================
  Files         414      414              
  Lines       12875    12882       +7     
  Branches     4488     4493       +5     
==========================================
- Hits         1876     1875       -1     
- Misses      10990    10998       +8     
  Partials        9        9              
Impacted Files Coverage Δ
src/components/FeeSelector/shared.tsx 0.00% <ø> (ø)
src/components/NavBar/ChainSelector.tsx 0.00% <ø> (ø)
src/components/NetworkAlert/NetworkAlert.tsx 0.00% <ø> (ø)
.../components/TransactionConfirmationModal/index.tsx 0.00% <0.00%> (ø)
src/components/Widget/inputs.tsx 0.00% <0.00%> (ø)
src/components/swap/styleds.tsx 0.00% <0.00%> (ø)
src/hooks/useClientSideV3Trade.ts 4.65% <ø> (ø)
src/hooks/useStablecoinPrice.ts 2.50% <ø> (ø)
src/lib/hooks/useCurrencyLogoURIs.ts 0.00% <0.00%> (ø)
src/lib/state/multicall.tsx 5.26% <0.00%> (-0.30%) ⬇️
... and 6 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JFrankfurt JFrankfurt requested review from a team, just-toby, zzmp, lynnshaoyu and callil and removed request for a team February 28, 2023 21:40
@JFrankfurt JFrankfurt marked this pull request as ready for review March 8, 2023 22:59
@JFrankfurt JFrankfurt merged commit d3085c1 into main Mar 15, 2023
@JFrankfurt JFrankfurt deleted the add-bsc-support branch March 15, 2023 14:00
@JFrankfurt JFrankfurt mentioned this pull request Jun 1, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants