Replace ERC-1155 With ERC-6909 For Multi-Token Accounting #358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #357
Description of changes
Gas Difference
Computed as
cost(ERC6909) - cost(ERC1155).Additional Notes
burn
Comparison is between
ERC1155.safeTransferFromandPoolManager.burn.These are functionally equivalent, though the
ERC1155.safeTransferFromperforms an additionalexternal call to itself for the burn step.
transferFrom
Comparison is between
ERC1155.safeTransferFromandERC6909.transferFrom.The
ERC1155.safeTransferFromsource isforge test --gas-reportbefore the ERC-6909 migration.The
ERC6909.transferFromsource isforge test --gas-reportfrom theERC-6909 repository.
setOperator
Comparison is between
ERC1155.setApprovalForAllandERC6909.setOperator, they are functionallyequivalent.