Add GCP IAM Conditions evidence gates#1728
Open
yanziwei wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Skill
gcp-reviewskills/cloud/gcp-review/SKILL.mdskills/cloud/gcp-review/benchmark-checklist.mdWhat Was Wrong
The GCP review skill covered IAM service account keys, admin privileges, service account role assignments, KMS access, API keys, and public grants, but it did not require evidence that temporary, scoped, emergency, contractor, or partner access is actually enforced with IAM Conditions or a JIT mechanism. Reviewers could accept comments, ticket due dates, or manual reminders as proof of temporary access even when the IAM binding itself was permanent.
It also did not warn that IAM Conditions do not apply to legacy basic roles or public principals, which can lead to false risk reduction claims for
roles/owner,roles/editor,roles/viewer,allUsers, orallAuthenticatedUsersgrants.What This PR Fixes
gcp-reviewto version1.0.1.IAM Conditions and Time-Bound Access Evidenceto the main workflow.request.time < timestamp(...)expiry.gcloud ... get-iam-policyexamples to the benchmark checklist.Test Cases / Validation
git diff --checkpassed.SKILL.mdfences: 4, balanced.benchmark-checklist.mdfences: 106, balanced.version: "1.0.1"IAM Conditions and Time-Bound Access Evidencerequest.time < timestampUnsupported Basic/Public Grantroles/ownerallAuthenticatedUsersconfiguring-temporary-accessConditional and Time-Bound Role BindingsBounty Tier
Moderate improver bounty requested: $100.
Closes #1727