Improve pipeline-security artifact integrity evidence#2000
Open
tiandashu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Skill Modified
Skill name: pipeline-security
Skill path:
skills/devsecops/pipeline-security/What Was Wrong
The skill evaluated CICD-SEC-9 by checking whether signatures, provenance, SBOMs, and digest pinning exist, but it did not require evidence that these controls are bound to the same artifact and enforced before deployment.
That can over-credit pipelines that generate attestations while deployments still pull mutable tags or skip verification.
Closes #1824.
What This PR Fixes
Evidencefield to detailed findings so reports preserve control-specific proof.Evidence
Before (skill misses this / false positive on this):
The pipeline generates signature/SBOM evidence, but deployment uses a mutable tag that is not verified.
After (now correctly handled):
Test Cases Added/Updated
tests/vulnerable/)tests/benign/)Bounty Tier
Bounty Info
Validation
git diff --check.github/workflows/lint-skills.yml: passed for 50 files.github/workflows/injection-scan.yml: passed.github/workflows/validate-index.yml: passed for 50 entries