Cleanup maven publication #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## neo #336 +/- ##
=========================================
Coverage 69.83% 69.83%
Complexity 2491 2491
=========================================
Files 275 275
Lines 15556 15556
Branches 2342 2342
=========================================
Hits 10863 10863
Misses 3768 3768
Partials 925 925 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Saloed
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary artifacts from maven publication, since they already present in components. In particular, when
includeDokkaisfalse, the corresponding task that composes a javadoc jar should not be executed and included as an artifact of the publication. The existing code contained the conditional setup ofdokkaJavadocJarartifact, but also erroneously included this artifact in the publication unconditionally. This PR should fix it.