-
Notifications
You must be signed in to change notification settings - Fork 1
feat: added dokku deployment configurations for production #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR adds Dokku deployment settings for production by updating the GitHub Actions workflow to target the main branch with secrets-based configuration, refining Procfile processes, and introducing an app.json for Dokku process formation and health checks. Class diagram for Procfile and app.json process formationclassDiagram
class App {
+web: gunicorn (2 workers, 2 threads)
+worker: celery worker -B
+beat: celery beat -l INFO
+release: python manage.py migrate
}
class Formation {
+web: quantity = 1
+worker: quantity = 1
+beat: quantity = 1
+release: quantity = 1
}
class Healthchecks {
+web: [type, name, description, path, attempts, interval, wait, initialDelay]
}
App o-- Formation
App o-- Healthchecks
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Bob-six - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `app.json:22` </location>
<code_context>
+ "type": "startup",
+ "name": "web check",
+ "description": "Checking if the app responds to the healthcheck endpoint",
+ "path": "/pass/art/1",
+ "attempts": 10,
+ "interval": "30s",
</code_context>
<issue_to_address>
The healthcheck path should be stable and lightweight.
Verify that '/pass/art/1' is suitable for healthchecks—always available, lightweight, and without side effects. If not, use a dedicated healthcheck endpoint.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
"path": "/pass/art/1",
=======
"path": "/health",
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| "type": "startup", | ||
| "name": "web check", | ||
| "description": "Checking if the app responds to the healthcheck endpoint", | ||
| "path": "/pass/art/1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: The healthcheck path should be stable and lightweight.
Verify that '/pass/art/1' is suitable for healthchecks—always available, lightweight, and without side effects. If not, use a dedicated healthcheck endpoint.
| "path": "/pass/art/1", | |
| "path": "/health", |
Summary by Sourcery
Configure production Dokku deployment by updating CI workflow, adjusting Procfile, and adding app.json.
Enhancements:
CI:
Deployment: