New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove boto3 and botocore in noDeploy to adhere to AWS best practices. #304

Open
tmclaugh opened this Issue Jan 7, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@tmclaugh
Copy link

tmclaugh commented Jan 7, 2019

Recently had a discussion with AWS employees about dependency handling and their recommendation is to bundle all your own packages, including boto3 and botocore. This is not the default behavior of serverless-python-requirements unfortunately. I've opened this issue to discuss removing those two packages or even rethink the noDeplopy option so it better aligns with AWS recommended practices.

@dschep

This comment has been minimized.

Copy link
Collaborator

dschep commented Jan 16, 2019

If AWS doesn't recommend using the boto3/botocore (and thus it's dependencies) that ship on Lambda, then I'm fully in favor of changing the noDeploy default to an empty list.

@tmclaugh

This comment has been minimized.

Copy link
Author

tmclaugh commented Jan 17, 2019

I'll get someone to respond to this from AWS.

@sthulb

This comment has been minimized.

Copy link

sthulb commented Jan 17, 2019

Hi all. I’m a SA for AWS.

Our leading practice is to ship your own version of boto with your app code either as a part of the handler zip or as a layer (for larger projects).

Feel free to reach out on the AWS Developers slack.

@bweigel

This comment has been minimized.

Copy link
Contributor

bweigel commented Jan 18, 2019

If someone wants to give this a shot, it should be a pretty straight-forward task. All that's needed is to change the default list in index.js and probably fix some tests after.

@jpadilla jpadilla referenced a pull request that will close this issue Jan 24, 2019

Open

Default `noDeploy` to an empty list #312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment