Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing docker builds will leave files owned as root #421

Open
Shados opened this issue Oct 25, 2019 · 0 comments

Comments

@Shados
Copy link

@Shados Shados commented Oct 25, 2019

pipCmds.push([
'chown',
'-R',
`${process.getuid()}:${process.getgid()}`,
dockerDownloadCacheDir
]);

^ This code never gets run if during the docker-run one of the Python package builds fails (e.g. due to missing some system dependency).

This will leave the download cache files owned by root, which will in turn prevent subsequent build attempts from working, due to this earlier attempt to open $downloadCacheDir/requriements.txt in write mode now being unable to succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.