Skip to content

Reaction role update#13

Merged
Pierre-Demessence merged 4 commits into
Unity-Developer-Community:reaction-rolefrom
SimplyJpk:reaction-role
May 3, 2021
Merged

Reaction role update#13
Pierre-Demessence merged 4 commits into
Unity-Developer-Community:reaction-rolefrom
SimplyJpk:reaction-role

Conversation

@SimplyJpk

Copy link
Copy Markdown
Member
  • Fixes a missed naming convention
  • reduces scope of ReactRoleUserData in class
  • Fixes the collision against newer command generation.

This should work with dev branch? Once we have setup a test message somewhere we'll want to bring a few people in to test this on the test server first just to make sure nothing is goof'd

SimplyJpk added 2 commits May 2, 2021 18:43
- Fixes a missed naming convention
- reduces scope of ReactRoleUserData in class
- Fixes the collision against newer command generation.
@Pierre-Demessence Pierre-Demessence changed the base branch from reaction-role to dev May 2, 2021 17:27
@Pierre-Demessence Pierre-Demessence changed the base branch from dev to reaction-role May 2, 2021 17:27
@Pierre-Demessence

Copy link
Copy Markdown
Member

Can you fix the conflicts in #3 first, so we can merge dev into reaction-role, and then this PR will be easier to understand 😄
(Because right now it contains all the commits of dev which have not been put into reaction-role which make it really hard to understand).

@Pierre-Demessence Pierre-Demessence merged commit 91b7d9f into Unity-Developer-Community:reaction-role May 3, 2021
@Pierre-Demessence Pierre-Demessence added this to the UDC Release milestone Jun 14, 2021
Pierre-Demessence added a commit that referenced this pull request Mar 31, 2026
- Create build-and-deploy.yml reusable workflow (workflow_call)
- Simplify deploy-dev.yml and deploy-prod.yml to thin wrappers
- Replace issue_comment trigger with workflow_dispatch for PR deploys
  (resolves CodeQL untrusted-checkout/high alert)
- Delete deploy-pr-build.yml and deploy-pr-push.yml (two-workflow split)
- Update pr-deploy-instructions.yml to reference Actions tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants