From 2dc76c50ef5ee56b0134825296e7b00fa664e419 Mon Sep 17 00:00:00 2001 From: FrancescoC-Unity Date: Tue, 14 Apr 2020 14:33:31 +0200 Subject: [PATCH 1/2] Follow references when unloading unneeded assets --- .../Editor/AssetProcessors/ShaderGraphMaterialsUpdater.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/com.unity.render-pipelines.high-definition/Editor/AssetProcessors/ShaderGraphMaterialsUpdater.cs b/com.unity.render-pipelines.high-definition/Editor/AssetProcessors/ShaderGraphMaterialsUpdater.cs index 3a3f94a9084..770e36cd1ef 100644 --- a/com.unity.render-pipelines.high-definition/Editor/AssetProcessors/ShaderGraphMaterialsUpdater.cs +++ b/com.unity.render-pipelines.high-definition/Editor/AssetProcessors/ShaderGraphMaterialsUpdater.cs @@ -55,13 +55,13 @@ static void OnShaderGraphSaved(Shader shader, object saveContext) // Free the materials every 200 iterations, on big project loading all materials in memory can lead to a crash if ((i % 200 == 0) && i != 0) - EditorUtility.UnloadUnusedAssetsImmediate(false); + EditorUtility.UnloadUnusedAssetsImmediate(true); } } finally { EditorUtility.ClearProgressBar(); - EditorUtility.UnloadUnusedAssetsImmediate(false); + EditorUtility.UnloadUnusedAssetsImmediate(true); } } } From 13d1da41dc9a7cc0ad10af2d5d2a46a38dbd3b92 Mon Sep 17 00:00:00 2001 From: FrancescoC-Unity Date: Wed, 15 Apr 2020 12:19:40 +0200 Subject: [PATCH 2/2] changelog --- com.unity.render-pipelines.high-definition/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md index 931c4151dd4..3fd695bef3a 100644 --- a/com.unity.render-pipelines.high-definition/CHANGELOG.md +++ b/com.unity.render-pipelines.high-definition/CHANGELOG.md @@ -39,6 +39,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed an issue where changing the default volume profile from another inspector would not update the default volume editor. - Fix for range compression factor for probes going negative (now clamped to positive values). - Fixed path validation when creating new volume profile (case 1229933) +- Fix for assertion triggering sometimes when saving a newly created lit shader graph (case 1230996) ### Changed - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history.