From 1c7e5857743d29cebdf91b65a81e20f449f767ac Mon Sep 17 00:00:00 2001 From: Antoine Lelievre Date: Wed, 15 Apr 2020 18:30:34 +0200 Subject: [PATCH 1/2] Only re-create the volume profile editor when the asset is changed --- .../Editor/RenderPipeline/Settings/DefaultSettingsPanel.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/Settings/DefaultSettingsPanel.cs b/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/Settings/DefaultSettingsPanel.cs index b244d14d284..35167715150 100644 --- a/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/Settings/DefaultSettingsPanel.cs +++ b/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/Settings/DefaultSettingsPanel.cs @@ -45,7 +45,7 @@ public class Styles ReorderableList m_BeforeTransparentCustomPostProcesses; ReorderableList m_BeforePostProcessCustomPostProcesses; ReorderableList m_AfterPostProcessCustomPostProcesses; - int m_CurrentVolumeProfileHash; + int m_CurrentVolumeProfileInstanceID; public void OnGUI(string searchContext) { @@ -209,9 +209,9 @@ void Draw_VolumeInspector() EditorGUILayout.EndHorizontal(); // The state of the profile can change without the asset reference changing so in this case we need to reset the editor. - if (m_CurrentVolumeProfileHash != asset.GetHashCode() && m_CachedDefaultVolumeProfileEditor != null) + if (m_CurrentVolumeProfileInstanceID != asset.GetInstanceID() && m_CachedDefaultVolumeProfileEditor != null) { - m_CurrentVolumeProfileHash = asset.GetHashCode(); + m_CurrentVolumeProfileInstanceID = asset.GetInstanceID(); m_CachedDefaultVolumeProfileEditor = null; } From 3fb2d1c3bb7a8d7aceb4ad8bd948cf99723f5e24 Mon Sep 17 00:00:00 2001 From: Antoine Lelievre Date: Wed, 15 Apr 2020 18:31:36 +0200 Subject: [PATCH 2/2] Updated changelog --- com.unity.render-pipelines.high-definition/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md index 1601942b91f..6128cff6821 100644 --- a/com.unity.render-pipelines.high-definition/CHANGELOG.md +++ b/com.unity.render-pipelines.high-definition/CHANGELOG.md @@ -532,6 +532,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed culling of planar reflection probes that change position (case 1218651) - Fixed null reference when processing lightprobe (case 1235285) - Fix issue causing wrong planar reflection rendering when more than one camera is present. +- Fixed an issue that was collapsing the volume components in the HDRP default settings ### Changed - Color buffer pyramid is not allocated anymore if neither refraction nor distortion are enabled