From dc3ea72dc44ca0937c255f9c16c8dc4e962e0a8a Mon Sep 17 00:00:00 2001 From: FrancescoC-Unity Date: Fri, 17 Apr 2020 10:41:48 +0200 Subject: [PATCH 1/2] fix warning --- .../Runtime/ShaderLibrary/ResolveStencilBuffer.compute | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/ResolveStencilBuffer.compute b/com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/ResolveStencilBuffer.compute index 89c740ed8a5..87fa3fc4707 100644 --- a/com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/ResolveStencilBuffer.compute +++ b/com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/ResolveStencilBuffer.compute @@ -79,7 +79,10 @@ void KERNEL_NAME(uint3 groupId : SV_GroupID, #else - bool isFirstThread = WaveIsFirstLane(); + // Need to workaround a warning incorrectly triggered when on Xbox One, so instead of using WaveIsFirstLane() + // we check the groupThreadId as in the non intrinsic version. + //bool isFirstThread = WaveIsFirstLane(); + bool isFirstThread = groupThreadId.x == 0 && groupThreadId.y == 0; uint coarseStencilValue = WaveActiveBitOr(resolvedStencil); #endif From 36d652e887c183370899c72efab497e15e00b22f Mon Sep 17 00:00:00 2001 From: FrancescoC-Unity Date: Fri, 17 Apr 2020 10:45:13 +0200 Subject: [PATCH 2/2] changelog --- com.unity.render-pipelines.high-definition/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md index ee5b4177476..26b5f348378 100644 --- a/com.unity.render-pipelines.high-definition/CHANGELOG.md +++ b/com.unity.render-pipelines.high-definition/CHANGELOG.md @@ -538,6 +538,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed white flash happening with auto-exposure in some cases (case 1223774) - Fixed NaN which can appear with real time reflection and inf value - Fixed an issue that was collapsing the volume components in the HDRP default settings +- Fixed shader warning on Xbox for ResolveStencilBuffer.compute. ### Changed - Color buffer pyramid is not allocated anymore if neither refraction nor distortion are enabled