From dfa46dcf2b8b07be44ab0402f807c1ab2138762c Mon Sep 17 00:00:00 2001 From: FrancescoC-Unity Date: Fri, 11 Sep 2020 15:35:13 +0200 Subject: [PATCH 1/2] Avoid to generate min16float4 --- .../Runtime/Lighting/Shadow/HDShadowManager.cs | 1 - .../Runtime/Lighting/Shadow/HDShadowManager.cs.hlsl | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs b/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs index 5b5d2eaf6b9..e47327f249e 100644 --- a/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs +++ b/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs @@ -48,7 +48,6 @@ struct HDShadowData public Vector4 zBufferParam; public Vector4 shadowMapSize; - [SurfaceDataAttributes(precision = FieldPrecision.Real)] public Vector4 shadowFilterParams0; public Vector3 cacheTranslationDelta; diff --git a/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs.hlsl b/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs.hlsl index 43c6844777e..c66758380ec 100644 --- a/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs.hlsl +++ b/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs.hlsl @@ -18,7 +18,7 @@ struct HDShadowData float normalBias; real4 zBufferParam; float4 shadowMapSize; - real4 shadowFilterParams0; + float4 shadowFilterParams0; float3 cacheTranslationDelta; float isInCachedAtlas; float4x4 shadowToWorld; From 29d38257c63b56756dbe7ee4264add560813047c Mon Sep 17 00:00:00 2001 From: FrancescoC-Unity Date: Fri, 11 Sep 2020 15:36:49 +0200 Subject: [PATCH 2/2] changelog --- com.unity.render-pipelines.high-definition/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md index b1ddaa3bb84..70da35d4515 100644 --- a/com.unity.render-pipelines.high-definition/CHANGELOG.md +++ b/com.unity.render-pipelines.high-definition/CHANGELOG.md @@ -70,6 +70,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed issue with stencil not being set in rendergraph mode. - Fixed for post process being overridable in reflection probes even though it is not supported. - Fixed RTGI in performance mode when light layers are enabled on the asset. +- Fix compilation issue on Vulkan for shaders using high quality shadows in XR mode. ### Changed - Preparation pass for RTSSShadows to be supported by render graph.