From a8aa29205cf46017c4c3767eab905585e5b3b9a3 Mon Sep 17 00:00:00 2001
From: Anis <anis@unity3d.com>
Date: Thu, 17 Sep 2020 17:04:50 +0200
Subject: [PATCH] Moving function to internal and adding doc for missing param
 in planar reflection function

---
 com.unity.render-pipelines.high-definition/CHANGELOG.md         | 1 +
 .../Lighting/Shadow/ScreenSpaceShadowManager.RenderGraph.cs     | 2 +-
 .../RenderPipeline/Raytracing/HDRaytracingRecursiveRenderer.cs  | 2 +-
 .../Runtime/Utilities/HDRenderUtilities.cs                      | 1 +
 4 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md
index c3ae54de7f0..d2c3f6e336c 100644
--- a/com.unity.render-pipelines.high-definition/CHANGELOG.md
+++ b/com.unity.render-pipelines.high-definition/CHANGELOG.md
@@ -80,6 +80,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed issue with mipmap debug mode not properly resetting full screen mode (and viceversa). 
 - Added unsupported message when using tile debug mode with MSAA.
 - Fixed SSGI compilation issues on PS4.
+- Moving function to internal and adding doc for missing param in planar reflection function.
 
 ### Changed
 - Preparation pass for RTSSShadows to be supported by render graph.
diff --git a/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/ScreenSpaceShadowManager.RenderGraph.cs b/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/ScreenSpaceShadowManager.RenderGraph.cs
index 88974134784..3987edec624 100644
--- a/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/ScreenSpaceShadowManager.RenderGraph.cs
+++ b/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/ScreenSpaceShadowManager.RenderGraph.cs
@@ -6,7 +6,7 @@ namespace UnityEngine.Rendering.HighDefinition
 {
     public partial class HDRenderPipeline
     {
-        public TextureHandle CreateScreenSpaceShadowTextureArray(RenderGraph renderGraph)
+        internal TextureHandle CreateScreenSpaceShadowTextureArray(RenderGraph renderGraph)
         {
             int numShadowTextures = Math.Max((int)Math.Ceiling(m_Asset.currentPlatformRenderPipelineSettings.hdShadowInitParams.maxScreenSpaceShadowSlots / 4.0f), 1);
             GraphicsFormat graphicsFormat = (GraphicsFormat)m_Asset.currentPlatformRenderPipelineSettings.hdShadowInitParams.screenSpaceShadowBufferFormat;
diff --git a/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/HDRaytracingRecursiveRenderer.cs b/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/HDRaytracingRecursiveRenderer.cs
index c22186c649d..4b6a79b667e 100644
--- a/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/HDRaytracingRecursiveRenderer.cs
+++ b/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/HDRaytracingRecursiveRenderer.cs
@@ -26,7 +26,7 @@ void InitRecursiveRenderer()
             m_FlagMaskTextureRT = RTHandles.Alloc(Vector2.one, TextureXR.slices, colorFormat: GraphicsFormat.R8_SNorm, dimension: TextureXR.dimension, enableRandomWrite: true, useDynamicScale: true, useMipMap: false, name: "FlagMaskTexture");
         }
 
-        public TextureHandle CreateFlagMaskTexture(RenderGraph renderGraph)
+        internal TextureHandle CreateFlagMaskTexture(RenderGraph renderGraph)
         {
             return renderGraph.CreateTexture(new TextureDesc(Vector2.one, true, true)
             {
diff --git a/com.unity.render-pipelines.high-definition/Runtime/Utilities/HDRenderUtilities.cs b/com.unity.render-pipelines.high-definition/Runtime/Utilities/HDRenderUtilities.cs
index b619c7ce519..0a4c32c0b22 100644
--- a/com.unity.render-pipelines.high-definition/Runtime/Utilities/HDRenderUtilities.cs
+++ b/com.unity.render-pipelines.high-definition/Runtime/Utilities/HDRenderUtilities.cs
@@ -371,6 +371,7 @@ public static RenderTexture CreateReflectionProbeRenderTarget(int cubemapSize, G
         /// Create the texture used as target for a realtime planar reflection probe.
         /// </summary>
         /// <param name="planarSize">The size of the texture</param>
+        /// <param name="format">The planar's format. It must match the format set in the asset.</param>
         /// <returns>The texture used as planar reflection probe target</returns>
         public static RenderTexture CreatePlanarProbeRenderTarget(int planarSize, GraphicsFormat format)
         {