From 06532445fcbc5cbba633ec2f91c8d7e871f1a77e Mon Sep 17 00:00:00 2001 From: Adrien de Tocqueville Date: Thu, 15 Oct 2020 15:48:53 +0200 Subject: [PATCH 1/3] Fix precision issue --- com.unity.render-pipelines.high-definition/CHANGELOG.md | 1 + .../OpaqueAtmosphericScattering.shader | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md index 0610721b359..3892f09687d 100644 --- a/com.unity.render-pipelines.high-definition/CHANGELOG.md +++ b/com.unity.render-pipelines.high-definition/CHANGELOG.md @@ -167,6 +167,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed cullmode for SceneSelectionPass. - Fixed issue that caused non-static object to not render at times in OnEnable reflection probes. - Fixed XR shadows culling. +- Fixed precision issue with the atmospheric fog. ### Changed - Preparation pass for RTSSShadows to be supported by render graph. diff --git a/com.unity.render-pipelines.high-definition/Runtime/Lighting/AtmosphericScattering/OpaqueAtmosphericScattering.shader b/com.unity.render-pipelines.high-definition/Runtime/Lighting/AtmosphericScattering/OpaqueAtmosphericScattering.shader index 28dd942da11..3954851f3ce 100644 --- a/com.unity.render-pipelines.high-definition/Runtime/Lighting/AtmosphericScattering/OpaqueAtmosphericScattering.shader +++ b/com.unity.render-pipelines.high-definition/Runtime/Lighting/AtmosphericScattering/OpaqueAtmosphericScattering.shader @@ -67,7 +67,7 @@ Shader "Hidden/HDRP/OpaqueAtmosphericScattering" float3 volColor, volOpacity; AtmosphericScatteringCompute(input, V, depth, volColor, volOpacity); - return float4(volColor, volOpacity.x); + return float4(volColor, 1.0 - volOpacity.x); } float4 FragMSAA(Varyings input, uint sampleIndex: SV_SampleIndex) : SV_Target @@ -80,7 +80,7 @@ Shader "Hidden/HDRP/OpaqueAtmosphericScattering" float3 volColor, volOpacity; AtmosphericScatteringCompute(input, V, depth, volColor, volOpacity); - return float4(volColor, volOpacity.x); + return float4(volColor, 1.0 - volOpacity.x); } float4 FragPBRFog(Varyings input) : SV_Target @@ -118,7 +118,7 @@ Shader "Hidden/HDRP/OpaqueAtmosphericScattering" Pass { Cull Off ZWrite Off - Blend One OneMinusSrcAlpha // Premultiplied alpha + Blend One SrcAlpha // Premultiplied alpha ZTest Less // Required for XR occlusion mesh optimization HLSLPROGRAM @@ -131,7 +131,7 @@ Shader "Hidden/HDRP/OpaqueAtmosphericScattering" Pass { Cull Off ZWrite Off - Blend One OneMinusSrcAlpha // Premultiplied alpha + Blend One SrcAlpha // Premultiplied alpha ZTest Less // Required for XR occlusion mesh optimization HLSLPROGRAM From abc20e2407c3cf662692cef88365c51fafe51d42 Mon Sep 17 00:00:00 2001 From: Adrien de Tocqueville Date: Tue, 20 Oct 2020 15:44:54 +0200 Subject: [PATCH 2/3] Update screenshots --- .../Linear/LinuxEditor/Vulkan/None/2008_Light_Volumetrics.png | 4 ++-- .../Linear/OSXEditor/Metal/None/2008_Light_Volumetrics.png | 4 ++-- .../WindowsEditor/Direct3D11/None/2008_Light_Volumetrics.png | 4 ++-- .../WindowsEditor/Direct3D12/None/2008_Light_Volumetrics.png | 4 ++-- .../WindowsEditor/Vulkan/None/2008_Light_Volumetrics.png | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/2008_Light_Volumetrics.png b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/2008_Light_Volumetrics.png index 7f97d186755..28f6e7a1265 100644 --- a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/2008_Light_Volumetrics.png +++ b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/2008_Light_Volumetrics.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:93aeaa803e352bd986c56ae125081855455a122449a0221572a1522e86cface4 -size 91361 +oid sha256:acedea51914670a28e3fe347590060e035e0529569c96c562fbe9fac932b74c1 +size 78768 diff --git a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/2008_Light_Volumetrics.png b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/2008_Light_Volumetrics.png index 51fb0019c94..28f6e7a1265 100644 --- a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/2008_Light_Volumetrics.png +++ b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/2008_Light_Volumetrics.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:5ae2bf1e606d8781e917d814352729786f5ca4976768561fd56473896c7320f9 -size 76886 +oid sha256:acedea51914670a28e3fe347590060e035e0529569c96c562fbe9fac932b74c1 +size 78768 diff --git a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/2008_Light_Volumetrics.png b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/2008_Light_Volumetrics.png index 4a68437f3b1..28f6e7a1265 100644 --- a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/2008_Light_Volumetrics.png +++ b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/2008_Light_Volumetrics.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:f22342a66275e9eb4cead092573b9b59b2f275dd0dadcfc15bc82a0307742e60 -size 78511 +oid sha256:acedea51914670a28e3fe347590060e035e0529569c96c562fbe9fac932b74c1 +size 78768 diff --git a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/2008_Light_Volumetrics.png b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/2008_Light_Volumetrics.png index 3bf193806b8..28f6e7a1265 100644 --- a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/2008_Light_Volumetrics.png +++ b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/2008_Light_Volumetrics.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:70029172b601592697f18d1343125e070655d6129397e3e53da3950846e19849 -size 91127 +oid sha256:acedea51914670a28e3fe347590060e035e0529569c96c562fbe9fac932b74c1 +size 78768 diff --git a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/None/2008_Light_Volumetrics.png b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/None/2008_Light_Volumetrics.png index 7f97d186755..deddd158657 100644 --- a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/None/2008_Light_Volumetrics.png +++ b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/None/2008_Light_Volumetrics.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:93aeaa803e352bd986c56ae125081855455a122449a0221572a1522e86cface4 -size 91361 +oid sha256:9230e827288ce0c750a3ecd95048819c999b82cfde786bbc4fe35a4729e300ab +size 78768 From 8012d3ee31585f357e0cdaec2a9cad7aa88a12ab Mon Sep 17 00:00:00 2001 From: Adrien de Tocqueville Date: Wed, 21 Oct 2020 11:55:57 +0200 Subject: [PATCH 3/3] Metal screenshot --- .../Linear/OSXEditor/Metal/None/2008_Light_Volumetrics.png | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/2008_Light_Volumetrics.png b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/2008_Light_Volumetrics.png index 28f6e7a1265..285f1803f08 100644 --- a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/2008_Light_Volumetrics.png +++ b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/2008_Light_Volumetrics.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:acedea51914670a28e3fe347590060e035e0529569c96c562fbe9fac932b74c1 -size 78768 +oid sha256:68724272add5feb7e6e8787634ac56109857b3d4534d6bbc7070d86bece45d76 +size 77168