From 44614cc3cfeb8071b43ef7fd647b5353313c64a4 Mon Sep 17 00:00:00 2001 From: Julien Ignace Date: Fri, 16 Oct 2020 17:49:49 +0200 Subject: [PATCH 1/2] LookDev menu item entry is now disabled if the current pipeline does not support it. --- .../Editor/LookDev/LookDev.cs | 6 ++++++ .../Editor/RenderPipeline/HDRenderPipelineEditor.cs | 9 --------- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/com.unity.render-pipelines.core/Editor/LookDev/LookDev.cs b/com.unity.render-pipelines.core/Editor/LookDev/LookDev.cs index 42064ef6989..7215994d059 100644 --- a/com.unity.render-pipelines.core/Editor/LookDev/LookDev.cs +++ b/com.unity.render-pipelines.core/Editor/LookDev/LookDev.cs @@ -46,6 +46,12 @@ static Context defaultContext internal static IViewDisplayer currentViewDisplayer => s_ViewDisplayer; internal static IEnvironmentDisplayer currentEnvironmentDisplayer => s_EnvironmentDisplayer; + [MenuItem("Window/Render Pipeline/Look Dev", false, 10200)] + static void OpenLookDev() => Open(); + + [MenuItem("Window/Render Pipeline/Look Dev", true, 10200)] + static bool LookDevAvailable() => supported; + /// State of the LookDev window public static bool open { get; private set; } diff --git a/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/HDRenderPipelineEditor.cs b/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/HDRenderPipelineEditor.cs index 7ebc0981a8b..27bd0705fba 100644 --- a/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/HDRenderPipelineEditor.cs +++ b/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/HDRenderPipelineEditor.cs @@ -34,13 +34,4 @@ public override void OnInspectorGUI() serialized.Apply(); } } - - // Moving lookdev menu to package implementing them. - // It must be done in editor scripts. - // Remaining of LookDev integration is done in HDRenderPipeline.LookDev - static class LookDevMenu - { - [MenuItem("Window/Render Pipeline/Look Dev", false, 10200)] - static void OpenLookDev() => LookDev.LookDev.Open(); - } } From f425ff9a56e87b7696eef3eaad0cc56993d9f8d7 Mon Sep 17 00:00:00 2001 From: Julien Ignace Date: Fri, 16 Oct 2020 17:51:44 +0200 Subject: [PATCH 2/2] Update changelog --- com.unity.render-pipelines.core/CHANGELOG.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/com.unity.render-pipelines.core/CHANGELOG.md b/com.unity.render-pipelines.core/CHANGELOG.md index b8d0d7d6339..44515d389d0 100644 --- a/com.unity.render-pipelines.core/CHANGELOG.md +++ b/com.unity.render-pipelines.core/CHANGELOG.md @@ -8,14 +8,15 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ### Added - Added context options "Move to Top", "Move to Bottom", "Expand All" and "Collapse All" for volume components. - -### Added - Added the support of input system V2 ### Fixed - Fixed the scene view to scale correctly when hardware dynamic resolution is enabled (case 1158661) - Fixed game view artifacts on resizing when hardware dynamic resolution was enabled +### Changed +- LookDev menu item entry is now disabled if the current pipeline does not support it. + ## [10.0.0] - 2019-06-10 ### Added