From 5f7012f3e9b8c96c2b1c273c21f82c2e0ec442cb Mon Sep 17 00:00:00 2001 From: FrancescoC-Unity Date: Thu, 12 Nov 2020 10:44:49 +0100 Subject: [PATCH 1/2] Redraw debug before re-registring the debugs --- .../Runtime/Debug/DebugDisplay.cs | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/com.unity.render-pipelines.high-definition/Runtime/Debug/DebugDisplay.cs b/com.unity.render-pipelines.high-definition/Runtime/Debug/DebugDisplay.cs index dd4fb552690..771d1497cf9 100644 --- a/com.unity.render-pipelines.high-definition/Runtime/Debug/DebugDisplay.cs +++ b/com.unity.render-pipelines.high-definition/Runtime/Debug/DebugDisplay.cs @@ -1008,56 +1008,62 @@ void RegisterMaterialDebug() void RefreshDisplayStatsDebug(DebugUI.Field field, T value) { UnregisterDebugItems(k_PanelDisplayStats, m_DebugDisplayStatsItems); - RegisterDisplayStatsDebug(); if (DebugManager.instance.displayRuntimeUI) DebugManager.instance.ReDrawOnScreenDebug(); + + RegisterDisplayStatsDebug(); } // For now we just rebuild the lighting panel if needed, but ultimately it could be done in a better way void RefreshLightingDebug(DebugUI.Field field, T value) { UnregisterDebugItems(k_PanelLighting, m_DebugLightingItems); - RegisterLightingDebug(); if (DebugManager.instance.displayRuntimeUI) DebugManager.instance.ReDrawOnScreenDebug(); + + RegisterLightingDebug(); } void RefreshDecalsDebug(DebugUI.Field field, T value) { UnregisterDebugItems(k_PanelDecals, m_DebugDecalsAffectingTransparentItems); - RegisterDecalsDebug(); if (DebugManager.instance.displayRuntimeUI) DebugManager.instance.ReDrawOnScreenDebug(); + + RegisterDecalsDebug(); } void RefreshRenderingDebug(DebugUI.Field field, T value) { UnregisterDebugItems(k_PanelRendering, m_DebugRenderingItems); - RegisterRenderingDebug(); if (DebugManager.instance.displayRuntimeUI) DebugManager.instance.ReDrawOnScreenDebug(); + + RegisterRenderingDebug(); } void RefreshMaterialDebug(DebugUI.Field field, T value) { UnregisterDebugItems(k_PanelMaterials, m_DebugMaterialItems); - RegisterMaterialDebug(); if (DebugManager.instance.displayRuntimeUI) DebugManager.instance.ReDrawOnScreenDebug(); + + RegisterMaterialDebug(); } void RefreshVolumeDebug(DebugUI.Field field, T value) { UnregisterDebugItems(k_PanelVolume, m_DebugVolumeItems); - RegisterVolumeDebug(); if (DebugManager.instance.displayRuntimeUI) DebugManager.instance.ReDrawOnScreenDebug(); + + RegisterVolumeDebug(); } void RegisterLightingDebug() From eb2ae47757006aafa95a51446230a612d725c409 Mon Sep 17 00:00:00 2001 From: FrancescoC-Unity Date: Thu, 12 Nov 2020 11:47:00 +0100 Subject: [PATCH 2/2] changelog --- com.unity.render-pipelines.high-definition/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md index c91b6526b68..8f747b3c0eb 100644 --- a/com.unity.render-pipelines.high-definition/CHANGELOG.md +++ b/com.unity.render-pipelines.high-definition/CHANGELOG.md @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ### Fixed - Fixed probe volumes debug views. +- Fixed issue displaying wrong debug mode in runtime debug menu UI. ## [10.2.0] - 2020-10-19