From c75e6c3b170a89e02f3390dc9bfcde437f0213c1 Mon Sep 17 00:00:00 2001 From: Emmanuel Turquin Date: Wed, 29 Apr 2020 18:44:45 +0200 Subject: [PATCH 1/4] Makes sure quaternion is normalized and valid before converting to matrix. --- .../Editor/Lighting/Reflection/PlanarReflectionProbeEditor.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/com.unity.render-pipelines.high-definition/Editor/Lighting/Reflection/PlanarReflectionProbeEditor.cs b/com.unity.render-pipelines.high-definition/Editor/Lighting/Reflection/PlanarReflectionProbeEditor.cs index cbece4f9ae9..4a37f1c8492 100644 --- a/com.unity.render-pipelines.high-definition/Editor/Lighting/Reflection/PlanarReflectionProbeEditor.cs +++ b/com.unity.render-pipelines.high-definition/Editor/Lighting/Reflection/PlanarReflectionProbeEditor.cs @@ -273,7 +273,7 @@ static void DrawCapturePositionGizmo(PlanarReflectionProbe probe) var mirrorPositionProxySpace = settings.proxySettings.mirrorPositionProxySpace + Vector3.up * 0.001f; var mirrorPosition = proxyToWorld.MultiplyPoint(mirrorPositionProxySpace); - var mirrorRotation = proxyToWorld.rotation * settings.proxySettings.mirrorRotationProxySpace * Quaternion.Euler(0, 180, 0); + var mirrorRotation = (proxyToWorld.rotation * settings.proxySettings.mirrorRotationProxySpace * Quaternion.Euler(0, 180, 0)).normalized; var renderData = probe.renderData; var gpuProj = GL.GetGPUProjectionMatrix(renderData.projectionMatrix, true); From 60e65b50f3ab7fc241556e1c8f46b680defe36e2 Mon Sep 17 00:00:00 2001 From: Emmanuel Turquin Date: Wed, 29 Apr 2020 22:17:25 +0200 Subject: [PATCH 2/4] Updated Changelo. --- com.unity.render-pipelines.high-definition/CHANGELOG.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md index d2ab7d1072e..95df364ab73 100644 --- a/com.unity.render-pipelines.high-definition/CHANGELOG.md +++ b/com.unity.render-pipelines.high-definition/CHANGELOG.md @@ -504,16 +504,16 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed an issue with refraction model and ray traced recursive rendering (case 1198578). - Fixed an issue where a dynamic sky changing any frame may not update the ambient probe. - Fixed cubemap thumbnail generation at project load time. -- Fixed cubemap thumbnail generation at project load time. +- Fixed cubemap thumbnail generation at project load time. - Fixed XR culling with multiple cameras - Fixed XR single-pass with Mock HMD plugin - Fixed sRGB mismatch with XR SDK - Fixed an issue where default volume would not update when switching profile. -- Fixed issue with uncached reflection probe cameras reseting the debug mode (case 1224601) +- Fixed issue with uncached reflection probe cameras reseting the debug mode (case 1224601) - Fixed an issue where AO override would not override specular occlusion. - Fixed an issue where Volume inspector might not refresh correctly in some cases. - Fixed render texture with XR -- Fixed issue with resources being accessed before initialization process has been performed completely. +- Fixed issue with resources being accessed before initialization process has been performed completely. - Half fixed shuriken particle light that cast shadows (only the first one will be correct) - Fixed issue with atmospheric fog turning black if a planar reflection probe is placed below ground level. (case 1226588) - Fixed custom pass GC alloc issue in CustomPassVolume.GetActiveVolumes(). @@ -552,7 +552,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed NaN which can appear with real time reflection and inf value - Fixed an issue that was collapsing the volume components in the HDRP default settings - Fixed warning about missing bound decal buffer -- Fixed shader warning on Xbox for ResolveStencilBuffer.compute. +- Fixed shader warning on Xbox for ResolveStencilBuffer.compute. - Fixed PBR shader ZTest rendering in deferred. - Replaced commands incompatible with async compute in light list build process. - Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. Note that the diffusion profile or the material references need to be edited once before this can work properly. @@ -568,6 +568,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed shadowmask UI now correctly showing shadowmask disable - Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. - Fixed a null ref exception in static sky when the default volume profile is invalid. +- Fixed an invalid rotation in Planar Reflection Probe editor display, that was causing an error message (case 1182022) ### Changed - Improve MIP selection for decals on Transparents From a49086f8fc581282a85afe0a434fa206eef16ddf Mon Sep 17 00:00:00 2001 From: Sebastien Lagarde Date: Wed, 6 May 2020 16:35:01 +0200 Subject: [PATCH 3/4] Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. --- com.unity.render-pipelines.high-definition/CHANGELOG.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md index 95df364ab73..d2ab7d1072e 100644 --- a/com.unity.render-pipelines.high-definition/CHANGELOG.md +++ b/com.unity.render-pipelines.high-definition/CHANGELOG.md @@ -504,16 +504,16 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed an issue with refraction model and ray traced recursive rendering (case 1198578). - Fixed an issue where a dynamic sky changing any frame may not update the ambient probe. - Fixed cubemap thumbnail generation at project load time. -- Fixed cubemap thumbnail generation at project load time. +- Fixed cubemap thumbnail generation at project load time. - Fixed XR culling with multiple cameras - Fixed XR single-pass with Mock HMD plugin - Fixed sRGB mismatch with XR SDK - Fixed an issue where default volume would not update when switching profile. -- Fixed issue with uncached reflection probe cameras reseting the debug mode (case 1224601) +- Fixed issue with uncached reflection probe cameras reseting the debug mode (case 1224601) - Fixed an issue where AO override would not override specular occlusion. - Fixed an issue where Volume inspector might not refresh correctly in some cases. - Fixed render texture with XR -- Fixed issue with resources being accessed before initialization process has been performed completely. +- Fixed issue with resources being accessed before initialization process has been performed completely. - Half fixed shuriken particle light that cast shadows (only the first one will be correct) - Fixed issue with atmospheric fog turning black if a planar reflection probe is placed below ground level. (case 1226588) - Fixed custom pass GC alloc issue in CustomPassVolume.GetActiveVolumes(). @@ -552,7 +552,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed NaN which can appear with real time reflection and inf value - Fixed an issue that was collapsing the volume components in the HDRP default settings - Fixed warning about missing bound decal buffer -- Fixed shader warning on Xbox for ResolveStencilBuffer.compute. +- Fixed shader warning on Xbox for ResolveStencilBuffer.compute. - Fixed PBR shader ZTest rendering in deferred. - Replaced commands incompatible with async compute in light list build process. - Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. Note that the diffusion profile or the material references need to be edited once before this can work properly. @@ -568,7 +568,6 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed shadowmask UI now correctly showing shadowmask disable - Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. - Fixed a null ref exception in static sky when the default volume profile is invalid. -- Fixed an invalid rotation in Planar Reflection Probe editor display, that was causing an error message (case 1182022) ### Changed - Improve MIP selection for decals on Transparents From 42a1f75619cafe9e77138cafa988ce60f0a0be71 Mon Sep 17 00:00:00 2001 From: Sebastien Lagarde Date: Wed, 6 May 2020 16:35:25 +0200 Subject: [PATCH 4/4] Update CHANGELOG.md --- com.unity.render-pipelines.high-definition/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md index d2ab7d1072e..eb779a6f9c6 100644 --- a/com.unity.render-pipelines.high-definition/CHANGELOG.md +++ b/com.unity.render-pipelines.high-definition/CHANGELOG.md @@ -568,6 +568,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed shadowmask UI now correctly showing shadowmask disable - Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. - Fixed a null ref exception in static sky when the default volume profile is invalid. +- Fixed an invalid rotation in Planar Reflection Probe editor display, that was causing an error message (case 1182022) ### Changed - Improve MIP selection for decals on Transparents