Why do you have this change here?

it is also for a custom render pipeline. I dunno if it worth specifying `{URP & HDRP}`

it is also for a custom render pipeline. I dunno if it worth specifying `{URP & HDRP}`

This should be removed

This should be removed

This should be removed

Should this be renamed to something else other than HDRP since it's in core?

I believe this won't work for gles2, but you can make it work similar to here: https://github.com/Unity-Technologies/Graphics/pull/4156/files#diff-a38bfa3320d1cc79f7e2f03bd3db8b2e82c77605cd0f44216dbb70e087c4892fR62-R80

```suggestion #include "Packages/com.unity.render-pipelines.core/Runtime/PostProcessing/Shaders/LensFlareCommon.hlsl" ``` I suggest naming failing without HDRP since it's in core package.

We need support for GLES2. Let's remove this line and try to in the editor and see if there are any compilation errors.

It is still odd to have spacing here. Why do you need space character ?

As this class is internal now, you don't need this anymore (but can keep it)

which can but ?

NICE !! ❤️

more than sealed, this should be static

label should be in a style class to not search them in the logic and it should be localizable. Please use either L18n or EditorGUIUtility.TrTextContent Plus here you have some spacing done with space character. Can you change it to either use indentation or displace directly the drawing rect starting point?

label should be in a style class to not search them in the logic and it should be localizable. Please use either **L18n** or **EditorGUIUtility.TrTextContent** Plus here you have some spacing done with space character. Can you change it to either use indentation or displace directly the drawing rect starting point?

public uneeded

Here you do it right: it is cached into the Editor. So you compute it once in OnEnable() and then only use it in OnInspectorGUI(). You should do the same than here for above comments.

remove public for editor

more than sealed, this should be static

Same here, this should be cached, not searched again at each GetPropertyHeight()

label should be in a style class to not search them in the logic and it should be localizable. Please use either **L18n** or **EditorGUIUtility.TrTextContent**

label should be in a style class to not search them in the logic and it should be localizable. Please use either **L18n** or **EditorGUIUtility.TrTextContent**

label should be in a style class to not search them in the logic and it should be localizable. Please use either **L18n** or **EditorGUIUtility.TrTextContent**

label should be in a style class to not search them in the logic and it should be localizable. Please use either **L18n** or **EditorGUIUtility.TrTextContent**

label should be in a style class to not search them in the logic and it should be localizable. Please use either **L18n** or **EditorGUIUtility.TrTextContent**

same here: this should be cached, not done at each OnGUI()

All of this should be constructed once and stored, not done at each OnGUI(). Finding property have a small cost that can be cached

label should be in a style class to not search them in the logic and it should be localizable. Please use either **L18n** or **EditorGUIUtility.TrTextContent**

label should be in a style class to not search them in the logic ( _EditorGUIUtility.TrTextContent("Lens Flare Element")_ )

Note: private is the default visibility for fields. You can drop them and still have same visibility

remove public for editor

More than sealed, this should be static

public unneeded

remove public for editor

There seems to be a lot more parameters than just the texture, should the comment reflect this?

Maybe "SRP Lens Flare Data Override" or just "SRP Lens Flare Override"?

This comment doesn't seem to make sense

another 'a' missing on name

missing an 'a' :)

And the editor can remain internal? We do not intend users to overwrite it?

Shouldn't this use the[ CustomEditorForRenderPipelineAttribute](https://docs.unity3d.com/ScriptReference/CustomEditorForRenderPipelineAttribute.html) instead?

| Allow Off Screen | Enable this property to allow lens flares outside the Camera's view to affect the current field of view. |

| Occlusion Offset | Offsets the plane that the occlusion operates on. A higher value moves this plane closer to Camera. This value is in world space. <br/> For example, if a lens flare is inside the light bulb, you can use this to sample occlusion outside the light bulb. |

**Q:** How does this property affect the Occlusion radius? I made a guess at this - feel free to adjust! **Suggested change:** | Sample Count | The number of random samples the CPU processes to generate the **Occlusion Radius.** |

| Occlusion Radius | Defines how far from the light source Unity occludes the lens flare. This value is in world space. |

| Enable | Enable this to occlude the lens flare based on the depth buffer |

| Screen Attenuation Curve | Reduces the effect of the lens flare based on its distance from the edge of the screen. You can use this to display a lens flare at the edge of your screen. |

| Scale Distance Curve | Changes the size of the lens flare over the distance between the GameObject this asset is attached to and the Camera |

| Scale Distance | The distance between the start and the end of the **Scale Distance Curve**. <br/> This value operates between 0 and 1 in world space. |

| Attenuation Distance Curve | Fades out the appearance of the lens flare over the distance between the GameObject this asset is attached to and the Camera. |

| Attenuation Distance | The distance between the start and the end of the **Attenuation Distance Curve**. <br/> This value operates between 0 and 1 in world space. |

**Q:** How does the type of light affect the behaviour of this property? **Suggested change:** | Attenuation by Light Shape | Reduces the effect of the lens flare based on the light type. <br/> This property is only available when this component is attached to a light. |

| Intensity | Multiplies the intensity of the lens flare. |

| Lens Flare Data | Select the [Lens Flare Element](srp-lens-flare-asset.md) asset this component controls. |

Three hashes needed: This section also needs a screenshot. ### Occlusion

Three hashes needed: ### General

Only two hashes needed: ## Properties

Unity’s Scriptable Render Pipeline (SRP) includes the SRP Lens Flare Override component to control a [SRP Lens Flare Data](srp-lens-flare-asset.md) asset. You can attach an SRP Lens Flare Override component to any GameObject. <br/> Some properties only appear when you attach this component to a light.

| Scale Variation | Controls the scale of the lens flares based on the **Seed** value. |

| Rotation Variation | Controls the rotation variation of the lens flares, based on the **Seed** value. This variation is added to **Rotation** and **Auto Rotate** parameters. |

| Position Variation | Controls the position of the lens flares. <br/> The **X** value is spread along the same axis as **Length Spread**. A value of 0 means there is no change in the lens flare position. <br/> The **Y** value is spread along the vertical screen space axis based on the **Seed** value. |

| Colors | The range of colors generated by the **Seed** value that this asset applies to the lens flares.|

**Q:** What determines if the value is "too high"? Is this value range 0-1? **Suggested change:** | Intensity Variation | Controls the variation of brightness across the lens flare elements. If this value is too high, some elements might not be visible. |

| Seed | The base value that this asset uses to generate randomness. |

| Scale Variation | | Adjust this curve to control the size range of the lens flare elements. |

| Position Spacing | Adjust this curve to change the placement of the flare element in the **Lens Spread**. |

| Colors | The range of colors that this asset applies to the lens flares. You can use the **Position Spacing** curve to determine how this range affects each lens flare.|

| Colors | The range of colors that this asset applies to the lens flares. |

| Length Spread | Controls how spread out the multiple lens flare elements appear. |

| Distribution | Select the method that Unity uses to generate multiple lens flare elements: <br />&#8226;[Uniform](#Uniform)<br />&#8226;[Curve](#Curve) <br />&#8226;[Random](#Random)|

| Count | Determines the number of identical lens flare elements Unity generates. <br/> A value of **1** appears the same as a single lens flare element.|

| Enable | Enable this to allow multiple lens flare elements in your scene. |

| Translation Scale | Limits the range of the lens flare offset. For example, values of (1, 0) create a horizontal lens flare, and (0, 1) create a vertical lens flare.<br/> You can also use this property to control the speed of the flare in its original path. For example, values of (0.5, 0.5) make the lens flare element appear to move at half the speed. |

**Q:** What is the Unit and value range of this property? **Suggested change:** | Angular Offset | Controls the angular offset of the lens flare, relative to its current position. |

| Position Offset | Defines the offset of the lens flare's position in screen space, relative to its source. |

**Q:** What is the value range and unit of this property? Also is its source always a light in the scene? **Suggested change:** | Starting Position | Defines the starting position of the lens flare relative to its source. |

| Auto Rotate | Enable this property to automatically rotate the Lens Flare Texture relative to its angle on the screen. Unity uses the **Auto Rotate** angle to override the **Rotation** parameter.<br/> To ensure the Lens Flare can rotate, assign a value greater than 0 to the [**Starting Position**](#AxisTransform) property. |

**Q:** What's the value and unit of this property?

| Size | Use this to adjust the scale of this lens flare element. <br/> This property is not available when the [**Type**](#Type) is set to [Image](#Image) and **Preserve Aspect Ratio** is enabled. |

**Q:** What is the range and unit of this value?

**Q:** Is this setting invisible or greyed out when this Lens Flare Element is not used in a SRP Lens Flare Override Component that is attached to a light? **Suggested change:** | Modulate By Light Color | Allows light color to affect this Lens Flare Element. This only applies when the asset is used in a [SRP Lens Flare Override Component](srp-lens-flare-component.md) that is attached to a light .|

**Q:** Could you please add a brief description of how each blend mode functions? **Suggested format change:** | Blend Mode | Select the blend mode of the Lens Flare Element this asset creates: <br />&#8226; Additive: Adds the color data together to increases the brightness of the lens flare. <br />&#8226; Screen: <br />&#8226; Premultiplied: <br />&#8226; Lerp: |

Q: What's the max value of this property? **Suggested change:** | Side Count | Controls the number of sides of the polygon flare. |

| Falloff | Controls the falloff of the polygon flare's gradient. This value ranges from 0 to 1, where 0 has no falloff between the tones and 1 creates a falloff that is spread evenly across the polygon. |

| Gradient | Controls the offset of the polygon flare's gradient. This value ranges from 0 to 1. |

| Falloff | Controls the falloff of the circular flare's gradient. This value ranges from 0 to 1, where 0 has no falloff between the tones and 1 creates a falloff that is spread evenly across the circle. |

| Roundness | Defines how smooth the edges of the polygon flare are. This value ranges from 0 to 1, where 0 is a sharp polygon and 1 is a circle. |

| Gradient | Controls the offset of the circular flare's gradient. This value ranges from 0 to 1. |

| Inverse | Enable this property to reverse the direction of the gradient. |

| Inverse | Enable this property to reverse the direction of the gradient. |

| Preserve Aspect Ratio | Fixes the width and height (aspect ratio) of the **Flare Texture**. You can use [Distortion](#Distortion) parameters to control this property. |

**Q:** How does this texture appear? Can we give a more detailed description or a visual example? **Suggested change:** | Flare Texture | The Texture used this Lens Flare Element uses. |

| **Property** | **Description** | | --------------- | ------------------------------------------------------------ | Type | Use the drop-down to select the type of Lens Flare Element this asset creates: <br />&#8226; [Image](#Image) <br />&#8226; [Circle](#Circle) <br />&#8226; [Polygon](#Polygon) |

Add header tag: <a name="Random"></a> ### Random

Add header tag: <a name="Curve"></a> ### Curve

Add header tag: <a name="Uniform"></a> ### Uniform

Add header tag: <a name="Multiple-Elements"></a> ## Multiple Elements

Add header tag: <a name="Distortion"></a> ## Distortion

Add header tag: <a name="AxisTransform"></a> ## AxisTransform

**Suggested change:** | Tint | Changes the tint of the Lens Flare texture based on the light this Lens Flare asset is attached to. |

Do these properties still exist in this component? If not, please disregard the below comments and remove this table.

**Q:** Does "intensity" refer to "brightness" here? If so: **Suggested change:** | Intensity | Controls the brightness of the entire Lens Flare. |

The Lens Flare Element asset has the following properties: - [Type](#Type) - [Image](#Image) - [Circle](#Circle) - [Polygon](#Polygon) - [Common](#Common) - [AxisTransform](#AxisTransform) - [Distortion](#Distortion) - [Multiple Elements](#Multiple-Elements) - [Uniform](#Uniform) - [Curve](#Curve) - [Random](#Random)

Add header tag: <a name="Polygon"></a> ### Polygon

Add header tag: <a name="Circle"></a> ### Circle

Add header tag: <a name="Image"></a> ### Image

Add header tag, insert description: <a name="Type"></a> ## Type

Two hashes - This encompasses all the following descriptions. ## Properties

| Intensity | Controls the brightness of this Lens Flare element. |

**Qs:** 1. If this asset _isn't_ used in an 'SRP Lens Flare Source Override', will this property still appear, or will it be greyed out? 2. How can the user include this asset in an SRP Lens Flare Source Override? That doesn't seem to be documented here.

| Tint | Controls the tint of the Texture applied to this Lens Flare Element. |

| Flare Texture | The Texture HDRP applies to this Lens Flare Element. |

| Elements | The properties of `SRPLensFlareDataElement`. |

**Q:** Same as above. I also changed "scale" to "position" here, assuming that's accurate :) **Suggested change:** | Position Curve | This curve affects the position of each Lens Flare element. When the relative position is negative, HDRP reads the negative part of the curve. When the relative position is positive, HDRP reads the negative part of the curve. <br/> The value of this curve is between -1 and 1. |

**Q:** What do you mean by "relative position" here? **Suggested change:** | Scale Curve | This curve affects the scale of each Lens Flare element. When the relative position is negative, HDRP reads the negative part of the curve. When the relative position is positive, HDRP reads the negative part of the curve. <br/> The value of this curve is between 0 and 1. |

**Suggested change:** The SRP Lens Flare asset has two groups of properties: - [Common](#Common): These properties affect the behavior of the whole Lens Flare - [Elements](#Elements): These properties affect the appearance of a single part of the Lens Flare.

Three hashes here, and a section tag. Also the heading in the UI appears to be "Elements": <a name="Elements"></a> ### Elements

**Q:** How specifically do you *create* a Lens Flare asset in the UI before you attach it to the SRP Lens Flare Override Component? **Suggested change:** Unity’s [Scriptable Render Pipeline (SRP)](https://docs.unity3d.com/Manual/ScriptableRenderPipeline.html) includes the **Lens Flare Element** asset. You can use this asset to create lens flares in your scene and control their appearance. <br/> To use this asset, assign it to the **Lens Flare Data** property of an [SRP Lens Flare Override Component](srp-lens-flare-component.md).

- New SRPLensFlareData asset

# Lens Flare