From ca6ed69a63252805821e1d324188143538480bb1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alex=20V=C3=A1zquez?= Date: Wed, 24 Feb 2021 09:25:34 +0100 Subject: [PATCH 1/3] Do not serialize UI properties on VolumeParameters --- .../Runtime/Volume/VolumeParameter.cs | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/com.unity.render-pipelines.core/Runtime/Volume/VolumeParameter.cs b/com.unity.render-pipelines.core/Runtime/Volume/VolumeParameter.cs index 9ad262e62ca..339c844fb6c 100644 --- a/com.unity.render-pipelines.core/Runtime/Volume/VolumeParameter.cs +++ b/com.unity.render-pipelines.core/Runtime/Volume/VolumeParameter.cs @@ -421,6 +421,7 @@ public class MinIntParameter : IntParameter /// /// The minimum value to clamp this parameter to. /// + [NonSerialized] public int min; /// @@ -465,6 +466,7 @@ public class NoInterpMinIntParameter : VolumeParameter /// /// The minimum value to clamp this parameter to. /// + [NonSerialized] public int min; /// @@ -509,6 +511,7 @@ public class MaxIntParameter : IntParameter /// /// The maximum value to clamp this parameter to. /// + [NonSerialized] public int max; /// @@ -553,6 +556,7 @@ public class NoInterpMaxIntParameter : VolumeParameter /// /// The maximum value to clamp this parameter to. /// + [NonSerialized] public int max; /// @@ -597,11 +601,13 @@ public class ClampedIntParameter : IntParameter /// /// The minimum value to clamp this parameter to. /// + [NonSerialized] public int min; /// /// The maximum value to clamp this parameter to. /// + [NonSerialized] public int max; /// @@ -648,11 +654,13 @@ public class NoInterpClampedIntParameter : VolumeParameter /// /// The minimum value to clamp this parameter to. /// + [NonSerialized] public int min; /// /// The maximum value to clamp this parameter to. /// + [NonSerialized] public int max; /// @@ -759,6 +767,7 @@ public class MinFloatParameter : FloatParameter /// /// The minimum value to clamp this parameter to. /// + [NonSerialized] public float min; /// @@ -805,6 +814,7 @@ public class NoInterpMinFloatParameter : VolumeParameter /// /// The minimum value to clamp this parameter to. /// + [NonSerialized] public float min; /// @@ -850,6 +860,7 @@ public class MaxFloatParameter : FloatParameter /// /// The maximum value to clamp this parameter to. /// + [NonSerialized] public float max; /// @@ -896,6 +907,7 @@ public class NoInterpMaxFloatParameter : VolumeParameter /// /// The maximum value to clamp this parameter to. /// + [NonSerialized] public float max; /// @@ -942,11 +954,13 @@ public class ClampedFloatParameter : FloatParameter /// /// The minimum value to clamp this parameter to. /// + [NonSerialized] public float min; /// /// The maximum value to clamp this parameter to. /// + [NonSerialized] public float max; /// @@ -995,11 +1009,13 @@ public class NoInterpClampedFloatParameter : VolumeParameter /// /// The minimum value to clamp this parameter to. /// + [NonSerialized] public float min; /// /// The maximum value to clamp this parameter to. /// + [NonSerialized] public float max; /// @@ -1048,11 +1064,13 @@ public class FloatRangeParameter : VolumeParameter /// /// The minimum value to clamp this parameter to. /// + [NonSerialized] public float min; /// /// The maximum value to clamp this parameter to. /// + [NonSerialized] public float max; /// @@ -1117,11 +1135,13 @@ public class NoInterpFloatRangeParameter : VolumeParameter /// /// The minimum value to clamp this parameter to. /// + [NonSerialized] public float min; /// /// The maximum value to clamp this parameter to. /// + [NonSerialized] public float max; /// @@ -1170,11 +1190,13 @@ public class ColorParameter : VolumeParameter /// /// Should the alpha channel be editable in the editor? /// + [NonSerialized] public bool showAlpha = true; /// /// Should the eye dropper be visible in the editor? /// + [NonSerialized] public bool showEyeDropper = true; /// @@ -1239,11 +1261,13 @@ public class NoInterpColorParameter : VolumeParameter /// /// Specifies whether you can edit the alpha channel in the Inspector or not. /// + [NonSerialized] public bool showAlpha = true; /// /// Specifies whether the eye dropper is visible in the editor or not. /// + [NonSerialized] public bool showEyeDropper = true; /// From db20ac13f2a1d17c10812d26a0d0c587eae70aa2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alex=20V=C3=A1zquez?= Date: Wed, 24 Feb 2021 09:35:57 +0100 Subject: [PATCH 2/3] Changelog --- com.unity.render-pipelines.core/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/com.unity.render-pipelines.core/CHANGELOG.md b/com.unity.render-pipelines.core/CHANGELOG.md index 7445575546a..85f779b895b 100644 --- a/com.unity.render-pipelines.core/CHANGELOG.md +++ b/com.unity.render-pipelines.core/CHANGELOG.md @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed missing warning UI about Projector component being unsupported (case 1300327). - Fixed the display name of a Volume Parameter when is defined the attribute InspectorName - Calculating correct rtHandleScale by considering the possible pixel rounding when DRS is on +- Problem on domain reload of Volume Parameter Ranges and UI values ### Added - Support for the PlayStation 5 platform has been added. From e502071ce188e9aff55ff37c74572a8e6ae7aee5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alex=20V=C3=A1zquez?= Date: Fri, 5 Mar 2021 12:13:47 +0100 Subject: [PATCH 3/3] Fix hdr update --- .../Runtime/Volume/VolumeParameter.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/com.unity.render-pipelines.core/Runtime/Volume/VolumeParameter.cs b/com.unity.render-pipelines.core/Runtime/Volume/VolumeParameter.cs index 339c844fb6c..f3fcd3ffdf4 100644 --- a/com.unity.render-pipelines.core/Runtime/Volume/VolumeParameter.cs +++ b/com.unity.render-pipelines.core/Runtime/Volume/VolumeParameter.cs @@ -1185,6 +1185,7 @@ public class ColorParameter : VolumeParameter /// /// Is this color HDR? /// + [NonSerialized] public bool hdr = false; ///