From 232ac8230c185cdf1d582ad4ddc85a8d493ea5fa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alex=20V=C3=A1zquez?= Date: Wed, 24 Feb 2021 17:25:07 +0100 Subject: [PATCH 1/2] [XPipeline]Fix crash on VolumeComponentWithQualityEditor when the current pipeline is not HDRP --- .../Editor/RenderPipeline/VolumeComponentWithQualityEditor.cs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/VolumeComponentWithQualityEditor.cs b/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/VolumeComponentWithQualityEditor.cs index 392332b145a..46d63a2591b 100644 --- a/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/VolumeComponentWithQualityEditor.cs +++ b/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/VolumeComponentWithQualityEditor.cs @@ -139,8 +139,7 @@ public override void OnEnable() // Ensure we reflect presets in the pipeline asset, not the hardcoded defaults. // Warning: base.OnEnable must be called after VolumeComponentWithQuality has unpacked SerializedData. - var pipeline = (HDRenderPipeline)RenderPipelineManager.currentPipeline; - if (pipeline != null) + if (RenderPipelineManager.currentPipeline is HDRenderPipeline pipeline) { serializedObject.Update(); From 0670d09976130174b67a06a8fbcd673f0bf1e6e5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alex=20V=C3=A1zquez?= Date: Wed, 24 Feb 2021 17:27:50 +0100 Subject: [PATCH 2/2] Changelog --- com.unity.render-pipelines.high-definition/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md index 637f00f3e73..c3dead6e8dc 100644 --- a/com.unity.render-pipelines.high-definition/CHANGELOG.md +++ b/com.unity.render-pipelines.high-definition/CHANGELOG.md @@ -54,6 +54,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed issue with compositor custom pass hooks added/removed repeatedly (case 1315971). - Fixed: SSR with transparent (case 1311088) - Fixed decals in material debug display. +- Fix crash on VolumeComponentWithQualityEditor when the current Pipeline is not HDRP - Fixed WouldFitInAtlas that would previously return wrong results if any one face of a point light would fit (it used to return true even though the light in entirety wouldn't fit).