From b92fdee010b2eeadda84d2d00b1b52ad58110223 Mon Sep 17 00:00:00 2001 From: Anis Benyoub Date: Fri, 26 Feb 2021 11:28:55 +0100 Subject: [PATCH 1/2] Fixed an issue in the planar reflection probe convolution. --- com.unity.render-pipelines.high-definition/CHANGELOG.md | 1 + .../Runtime/Lighting/PlanarReflectionFiltering.compute | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md index 0110e8e7c3f..d8ced9a8e4a 100644 --- a/com.unity.render-pipelines.high-definition/CHANGELOG.md +++ b/com.unity.render-pipelines.high-definition/CHANGELOG.md @@ -61,6 +61,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed WouldFitInAtlas that would previously return wrong results if any one face of a point light would fit (it used to return true even though the light in entirety wouldn't fit). - Fixed issue with NaNs in Volumetric Clouds on some platforms. - Fixed update upon light movement for directional light rotation. +- Fixed an issue in the planar reflection probe convolution. ### Changed - Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard diff --git a/com.unity.render-pipelines.high-definition/Runtime/Lighting/PlanarReflectionFiltering.compute b/com.unity.render-pipelines.high-definition/Runtime/Lighting/PlanarReflectionFiltering.compute index dd55fdadfef..64d4e37a547 100644 --- a/com.unity.render-pipelines.high-definition/Runtime/Lighting/PlanarReflectionFiltering.compute +++ b/com.unity.render-pipelines.high-definition/Runtime/Lighting/PlanarReflectionFiltering.compute @@ -148,8 +148,8 @@ void DownScale(uint3 dispatchThreadId : SV_DispatchThreadID, uint2 groupThreadId { const int2 tapCoord = currentCoord * 2 + uint2(x, y); // If the pixel is outside the current screen size, its weight becomes zero - float weight = tapCoord.x > _CaptureCurrentScreenSize.x || tapCoord.x < 0 - || tapCoord.y > _CaptureCurrentScreenSize.y || tapCoord.y < 0 ? 0.0 : 1.0; + float weight = tapCoord.x >= _CaptureCurrentScreenSize.x || tapCoord.x < 0 + || tapCoord.y >= _CaptureCurrentScreenSize.y || tapCoord.y < 0 ? 0.0 : 1.0; averageColor += LOAD_TEXTURE2D_LOD(_ReflectionColorMipChain, tapCoord, _SourceMipIndex).xyz * weight; sumW += weight; } From 4f91cfbeb77b4f526de2b42258323fa02e88196f Mon Sep 17 00:00:00 2001 From: Anis Benyoub Date: Mon, 1 Mar 2021 09:38:39 +0100 Subject: [PATCH 2/2] Udpating the screenshots --- .../Linear/LinuxEditor/Vulkan/None/2203_PlanarProbes.png | 4 ++-- .../LinuxEditor/Vulkan/None/2220_SmoothPlanarReflection.png | 4 ++-- .../WindowsEditor/Direct3D11/None/2203_PlanarProbes.png | 4 ++-- .../Direct3D11/None/2220_SmoothPlanarReflection.png | 4 ++-- .../WindowsEditor/Direct3D12/None/2203_PlanarProbes.png | 4 ++-- .../Direct3D12/None/2220_SmoothPlanarReflection.png | 4 ++-- .../Linear/WindowsEditor/Vulkan/None/2203_PlanarProbes.png | 4 ++-- .../WindowsEditor/Vulkan/None/2220_SmoothPlanarReflection.png | 4 ++-- 8 files changed, 16 insertions(+), 16 deletions(-) diff --git a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/2203_PlanarProbes.png b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/2203_PlanarProbes.png index 0d2db277cb8..601cd6483d2 100644 --- a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/2203_PlanarProbes.png +++ b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/2203_PlanarProbes.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:2c2404848b74f836a33eacaebddf9d39ff9051dcf60e299b96867c320c2c867a -size 199328 +oid sha256:46edac4447cc323137e4d5272afded2ceeb27a8627658aff81ef7656e8aa6f95 +size 202999 diff --git a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/2220_SmoothPlanarReflection.png b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/2220_SmoothPlanarReflection.png index 365bf9ce4b5..05766d1e2b1 100644 --- a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/2220_SmoothPlanarReflection.png +++ b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/LinuxEditor/Vulkan/None/2220_SmoothPlanarReflection.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:28144b01e81901df5ac133426cfca12fa98418e04c3192d810abf2b3bc89ee07 -size 86199 +oid sha256:cbc21e7d732e3aa83de2c20fbf1c83e6211bac1050a76b140c4f58e4e7e7415d +size 72120 diff --git a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/2203_PlanarProbes.png b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/2203_PlanarProbes.png index 0d2db277cb8..c282f7b33af 100644 --- a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/2203_PlanarProbes.png +++ b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/2203_PlanarProbes.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:2c2404848b74f836a33eacaebddf9d39ff9051dcf60e299b96867c320c2c867a -size 199328 +oid sha256:f118ebdc84ed48803ecff7955e148d35a8300e9842362435cb9a17ee2eedead3 +size 202784 diff --git a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/2220_SmoothPlanarReflection.png b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/2220_SmoothPlanarReflection.png index 904536ae9ba..79c13a010f6 100644 --- a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/2220_SmoothPlanarReflection.png +++ b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/2220_SmoothPlanarReflection.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:bebcd93c19fe39d5be990a4626ef17aec0c426e70ffb5ac86fd7a849c6b77394 -size 74131 +oid sha256:602d4fbb73442e4891115bf378fdd6d59c01053d1b13017c7fba1653292d32c2 +size 72146 diff --git a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/2203_PlanarProbes.png b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/2203_PlanarProbes.png index 0d2db277cb8..5a551d8ceec 100644 --- a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/2203_PlanarProbes.png +++ b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/2203_PlanarProbes.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:2c2404848b74f836a33eacaebddf9d39ff9051dcf60e299b96867c320c2c867a -size 199328 +oid sha256:156252597240686296ccccf0b6114d226893354166f1c5d64cc62f4fd458ce7c +size 202778 diff --git a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/2220_SmoothPlanarReflection.png b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/2220_SmoothPlanarReflection.png index 6e73999ec5c..93c491eae1c 100644 --- a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/2220_SmoothPlanarReflection.png +++ b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/2220_SmoothPlanarReflection.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:338814a551aff45c57516d627fddacea9d791db63aa29df6cea0c171af93eb5e -size 86171 +oid sha256:d50bdfaf57c22c8b92e9ae8d4a5344ed9f82d774266c25885319ec693a5d030e +size 72147 diff --git a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/None/2203_PlanarProbes.png b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/None/2203_PlanarProbes.png index 0d2db277cb8..48a96810519 100644 --- a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/None/2203_PlanarProbes.png +++ b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/None/2203_PlanarProbes.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:2c2404848b74f836a33eacaebddf9d39ff9051dcf60e299b96867c320c2c867a -size 199328 +oid sha256:166daf5a03ab0b3127c8a1c445b3618a291189d166eb4f2b63547be69cdc20c0 +size 202981 diff --git a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/None/2220_SmoothPlanarReflection.png b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/None/2220_SmoothPlanarReflection.png index 365bf9ce4b5..05766d1e2b1 100644 --- a/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/None/2220_SmoothPlanarReflection.png +++ b/TestProjects/HDRP_Tests/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/None/2220_SmoothPlanarReflection.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:28144b01e81901df5ac133426cfca12fa98418e04c3192d810abf2b3bc89ee07 -size 86199 +oid sha256:cbc21e7d732e3aa83de2c20fbf1c83e6211bac1050a76b140c4f58e4e7e7415d +size 72120