From cdf371f3e2d53a966bc78733375d6a45228e2c24 Mon Sep 17 00:00:00 2001 From: FrancescoC-Unity Date: Thu, 8 Apr 2021 10:16:31 +0200 Subject: [PATCH 1/2] Fix ondemand shadow assert --- .../Runtime/Lighting/Shadow/HDCachedShadowAtlas.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDCachedShadowAtlas.cs b/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDCachedShadowAtlas.cs index 5c968626fd5..7f0f139e7f3 100644 --- a/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDCachedShadowAtlas.cs +++ b/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDCachedShadowAtlas.cs @@ -618,7 +618,8 @@ internal void MarkAsRendered(int shadowIdx) if (m_ShadowsPendingRendering.ContainsKey(shadowIdx)) { m_ShadowsPendingRendering.Remove(shadowIdx); - m_ShadowsWithValidData.Add(shadowIdx, shadowIdx); + if (!m_ShadowsWithValidData.ContainsKey(shadowIdx)) + m_ShadowsWithValidData.Add(shadowIdx, shadowIdx); } } From 5adec5db06de6975b262121aff69fc9a9ffa3808 Mon Sep 17 00:00:00 2001 From: FrancescoC-Unity Date: Thu, 8 Apr 2021 10:17:16 +0200 Subject: [PATCH 2/2] Changelog # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md --- com.unity.render-pipelines.high-definition/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md index 81158c24c67..83888125fb1 100644 --- a/com.unity.render-pipelines.high-definition/CHANGELOG.md +++ b/com.unity.render-pipelines.high-definition/CHANGELOG.md @@ -135,6 +135,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed a bug with Reflection Probe baking would result in an incorrect baking reusing other's Reflection Probe baking - Fixed volumetric fog being visually chopped or missing when using hardware Dynamic Resolution Scaling. - Fixed generation of the packed depth pyramid when hardware Dynamic Resolution Scaling is enabled. +- Fix issue with an assert getting triggered with OnDemand shadows. ### Changed - Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard