[VFX] Use New Overlay for VFXEventTest & VisualEffectEditor #4407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neViewOverlay I'm using this similar change as reference : https://ono.unity3d.com/unity/from-git/diff-2way/Modules/ParticleSystemEditor/ParticleEffectUI.cs?diff2=98ee5a3e7c2b1bcafcc6b01a687c0536e03baca8&diff1=71a161db37e24385d48e3d72f5cfe23f50a1665f&fulldiff=1&diff=diff
PaulDemeulenaere
changed the title
julienf-unity
approved these changes
May 3, 2021
arttu-peltonen
approved these changes
May 3, 2021
|
Adding the test doc for visibility. Didn't detect any functionality issues, however UX may require some tweaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Use new overlay system introduced at https://ono.unity3d.com/unity/unity/pull-request/124057/_/st/overlays/main
Testing status
VFX Event Windows
VFX Gizmo
Yamato
🟢
Comments to reviewers
Mainly fixes the compilation, the design isn't ideal and some simplification could be done.
I used this change as reference.
See also this conversation : https://unity.slack.com/archives/CFZERNTS7/p1620035900277000?thread_ts=1620027935.262100&cid=CFZERNTS7