From febec304315893d16ed914d6cf23b62b3dd93723 Mon Sep 17 00:00:00 2001 From: sebastienlagarde Date: Thu, 14 May 2020 12:52:38 +0200 Subject: [PATCH] Revert "Disable async compute for D3D12 [Hold] (#301)" This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. --- .../Documentation~/Frame-Settings.md | 1 - .../Runtime/RenderPipeline/Settings/FrameSettings.cs | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/com.unity.render-pipelines.high-definition/Documentation~/Frame-Settings.md b/com.unity.render-pipelines.high-definition/Documentation~/Frame-Settings.md index 7e3832e0cd3..8037715e3ac 100644 --- a/com.unity.render-pipelines.high-definition/Documentation~/Frame-Settings.md +++ b/com.unity.render-pipelines.high-definition/Documentation~/Frame-Settings.md @@ -93,7 +93,6 @@ These settings control lighting features for your rendering components. Here you ### Asynchronous Compute Shaders These settings control which effects, if any, can make use execute compute Shader commands in parallel. -Note that these settings will have an effect only if asynchronous compute is supported by the target platform. | **Property** | **Description** | | ---------------------------------- | ------------------------------------------------------------ | diff --git a/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Settings/FrameSettings.cs b/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Settings/FrameSettings.cs index 677eb6edf54..377cdd9624a 100644 --- a/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Settings/FrameSettings.cs +++ b/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Settings/FrameSettings.cs @@ -765,8 +765,7 @@ internal static void Sanitize(ref FrameSettings sanitizedFrameSettings, Camera c sanitizedFrameSettings.bitDatas[(int)FrameSettingsField.Distortion] &= renderPipelineSettings.supportDistortion && !msaa && !preview; sanitizedFrameSettings.bitDatas[(int)FrameSettingsField.LowResTransparent] &= renderPipelineSettings.lowresTransparentSettings.enabled; - // NOTE: We currently disable async compute on D3D12 for an issue we have with constant buffer update. TODO We need to renable it when case 1238431 is resolved - bool async = sanitizedFrameSettings.bitDatas[(int)FrameSettingsField.AsyncCompute] &= (SystemInfo.supportsAsyncCompute && SystemInfo.graphicsDeviceType != GraphicsDeviceType.Direct3D12); + bool async = sanitizedFrameSettings.bitDatas[(int)FrameSettingsField.AsyncCompute] &= SystemInfo.supportsAsyncCompute; sanitizedFrameSettings.bitDatas[(int)FrameSettingsField.LightListAsync] &= async; sanitizedFrameSettings.bitDatas[(int)FrameSettingsField.SSRAsync] &= (async && !rayTracingActive); sanitizedFrameSettings.bitDatas[(int)FrameSettingsField.SSAOAsync] &= (async && !rayTracingActive);