From bbc8f722cfdbe554693e313f6593d75b7b9288d7 Mon Sep 17 00:00:00 2001 From: Remi Chapelain Date: Mon, 30 Aug 2021 12:01:03 +0200 Subject: [PATCH 1/5] adding bit of info --- .../Documentation~/Override-Screen-Space-GI.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md b/com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md index a96db2acad0..3a4c9f47176 100644 --- a/com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md +++ b/com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md @@ -74,6 +74,12 @@ HDRP uses the [Volume](Volumes.md) framework to calculate SSGI, so to enable and ## Limitations +In Deferred rendering mode, Screen Space Global Illumination and Ray-Traced Global Illumination share a buffer with emissive thus overwriting emissive data. +There is multiple ways to recover the emissive contribution of the scene materials: +* Disabling Receive SSR/SSGI flag on the emissive materials. +* Using Force Forward Emissive on the emissive materials. +* Using Forward rendering. + ### Screen-space global illumination * When rendering [Reflection Probes](Reflection-Probe.md) screen space global illumination is not supported. From 444ea8f8cb5f021d802323f258c9f65103d58abc Mon Sep 17 00:00:00 2001 From: Remi Chapelain Date: Mon, 30 Aug 2021 16:09:22 +0200 Subject: [PATCH 2/5] Adding links --- .../Documentation~/Override-Screen-Space-GI.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md b/com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md index 3a4c9f47176..7f3dae2e98f 100644 --- a/com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md +++ b/com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md @@ -76,8 +76,8 @@ HDRP uses the [Volume](Volumes.md) framework to calculate SSGI, so to enable and In Deferred rendering mode, Screen Space Global Illumination and Ray-Traced Global Illumination share a buffer with emissive thus overwriting emissive data. There is multiple ways to recover the emissive contribution of the scene materials: -* Disabling Receive SSR/SSGI flag on the emissive materials. -* Using Force Forward Emissive on the emissive materials. +* Disabling [Receive SSR/SSGI](snippets/shader-properties/surface-options/freceive-ssr.md) flag on the emissive materials. +* Using [Force Forward Emissive](snippets/shader-properties/advanced-options/force-forward-emissive.md) on the emissive materials. * Using Forward rendering. ### Screen-space global illumination From b0a7dcc1e515b2ed9cf02be465f6b00e55e9ee24 Mon Sep 17 00:00:00 2001 From: Remi Chapelain Date: Mon, 30 Aug 2021 16:10:30 +0200 Subject: [PATCH 3/5] fixing typo --- .../Documentation~/Override-Screen-Space-GI.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md b/com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md index 7f3dae2e98f..c587b4e88bf 100644 --- a/com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md +++ b/com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md @@ -76,7 +76,7 @@ HDRP uses the [Volume](Volumes.md) framework to calculate SSGI, so to enable and In Deferred rendering mode, Screen Space Global Illumination and Ray-Traced Global Illumination share a buffer with emissive thus overwriting emissive data. There is multiple ways to recover the emissive contribution of the scene materials: -* Disabling [Receive SSR/SSGI](snippets/shader-properties/surface-options/freceive-ssr.md) flag on the emissive materials. +* Disabling [Receive SSR/SSGI](snippets/shader-properties/surface-options/receive-ssr.md) flag on the emissive materials. * Using [Force Forward Emissive](snippets/shader-properties/advanced-options/force-forward-emissive.md) on the emissive materials. * Using Forward rendering. From 0ce03c4f170413ac0f13c786aad2b7653906572d Mon Sep 17 00:00:00 2001 From: Remi Chapelain Date: Wed, 1 Sep 2021 13:14:35 +0200 Subject: [PATCH 4/5] Helpbox in SSGI override --- .../RenderPipeline/Raytracing/GlobalIlluminationEditor.cs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/Raytracing/GlobalIlluminationEditor.cs b/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/Raytracing/GlobalIlluminationEditor.cs index b27e5d13731..f8352fb003e 100644 --- a/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/Raytracing/GlobalIlluminationEditor.cs +++ b/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/Raytracing/GlobalIlluminationEditor.cs @@ -173,7 +173,10 @@ public override void OnInspectorGUI() } PropertyField(m_Enable); - + if (m_Enable.value.boolValue) + EditorGUILayout.HelpBox("Real-time Global Illumination overwrites emissive data in deferred rendering mode. To recover the emissive contribution, either use Force Forward Emissive or disable Receive SSR/SSGI flag on the emissive materials.", MessageType.Info); + EditorGUILayout.Space(); + // If ray tracing is supported display the content of the volume component if (HDRenderPipeline.buildPipelineSupportsRayTracing) PropertyField(m_Tracing); From 83e2e01e458a5a9855b100e41958f2f891124372 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Chapelain?= <57442369+remi-chapelain@users.noreply.github.com> Date: Thu, 2 Sep 2021 16:02:17 +0200 Subject: [PATCH 5/5] Apply suggestions from code review Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> --- .../Documentation~/Override-Screen-Space-GI.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md b/com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md index c587b4e88bf..5656481a28b 100644 --- a/com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md +++ b/com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md @@ -74,11 +74,11 @@ HDRP uses the [Volume](Volumes.md) framework to calculate SSGI, so to enable and ## Limitations -In Deferred rendering mode, Screen Space Global Illumination and Ray-Traced Global Illumination share a buffer with emissive thus overwriting emissive data. -There is multiple ways to recover the emissive contribution of the scene materials: -* Disabling [Receive SSR/SSGI](snippets/shader-properties/surface-options/receive-ssr.md) flag on the emissive materials. -* Using [Force Forward Emissive](snippets/shader-properties/advanced-options/force-forward-emissive.md) on the emissive materials. -* Using Forward rendering. +In Deferred rendering mode, Screen Space Global Illumination and Ray-Traced Global Illumination share a buffer with emissive, which overwrites emissive data. +There are multiple ways to recover the emissive contribution of the scene materials: +* Disable [Receive SSR/SSGI](snippets/shader-properties/surface-options/receive-ssr.md) flag on the emissive materials. +* Use [Force Forward Emissive](snippets/shader-properties/advanced-options/force-forward-emissive.md) on the emissive materials. +* Use Forward rendering. ### Screen-space global illumination