diff --git a/com.unity.shadergraph/CHANGELOG.md b/com.unity.shadergraph/CHANGELOG.md index 4787fd02bd6..3767a190403 100644 --- a/com.unity.shadergraph/CHANGELOG.md +++ b/com.unity.shadergraph/CHANGELOG.md @@ -138,6 +138,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fixed the ordering of inputs on a SubGraph node to match the properties on the blackboard of the subgraph itself [1366052] - Fixed Parallax Occlusion Mapping node to handle non-uniformly scaled UVs such as HDRP/Lit POM [1347008]. - Fixed ShaderGraph HDRP master preview disappearing for a few seconds when graph is modified [1330289] (https://issuetracker.unity3d.com/issues/shadergraph-hdrp-main-preview-is-invisible-until-moved) +- Fixed an issue where ShaderGraph "view shader" commands were opening in individual windows, and blocking Unity from closing [1367188] ## [11.0.0] - 2020-10-21 diff --git a/com.unity.shadergraph/Editor/Data/Util/GraphUtil.cs b/com.unity.shadergraph/Editor/Data/Util/GraphUtil.cs index f578776d809..624604286a0 100644 --- a/com.unity.shadergraph/Editor/Data/Util/GraphUtil.cs +++ b/com.unity.shadergraph/Editor/Data/Util/GraphUtil.cs @@ -362,26 +362,6 @@ public static bool WriteToFile(string path, string content) } } - static ProcessStartInfo CreateProcessStartInfo(string filePath) - { - string externalScriptEditor = ScriptEditorUtility.GetExternalScriptEditor(); - - ProcessStartInfo psi = new ProcessStartInfo(); - psi.UseShellExecute = false; - - -#if UNITY_EDITOR_OSX - string arg = string.Format("-a \"{0}\" -n --args \"{1}\"", externalScriptEditor, Path.GetFullPath(filePath)); - psi.FileName = "open"; - psi.Arguments = arg; -#else - psi.Arguments = Path.GetFileName(filePath); - psi.WorkingDirectory = Path.GetDirectoryName(filePath); - psi.FileName = externalScriptEditor; -#endif - return psi; - } - public static void OpenFile(string path) { string filePath = Path.GetFullPath(path); @@ -394,8 +374,7 @@ public static void OpenFile(string path) string externalScriptEditor = ScriptEditorUtility.GetExternalScriptEditor(); if (externalScriptEditor != "internal") { - ProcessStartInfo psi = CreateProcessStartInfo(filePath); - Process.Start(psi); + InternalEditorUtility.OpenFileAtLineExternal(filePath, 0); } else {