From 1cf27214604e581604ed1d0aca3a07705ae09286 Mon Sep 17 00:00:00 2001 From: Nigel John Williams Date: Thu, 30 Sep 2021 11:19:28 +0200 Subject: [PATCH 1/3] Fixed typo in API name --- .../Runtime/Data/UniversalRenderPipelineAsset.cs | 2 +- .../Runtime/UniversalRenderer.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/com.unity.render-pipelines.universal/Runtime/Data/UniversalRenderPipelineAsset.cs b/com.unity.render-pipelines.universal/Runtime/Data/UniversalRenderPipelineAsset.cs index 8e14cca2516..14bd50a0272 100644 --- a/com.unity.render-pipelines.universal/Runtime/Data/UniversalRenderPipelineAsset.cs +++ b/com.unity.render-pipelines.universal/Runtime/Data/UniversalRenderPipelineAsset.cs @@ -924,7 +924,7 @@ public bool conservativeEnclosingSphere set { m_ConservativeEnclosingSphere = value; } } - public int numItertionsEnclosingSphere + public int numIterationsEnclosingSphere { get { return m_NumIterationsEnclosingSphere; } set { m_NumIterationsEnclosingSphere = value; } diff --git a/com.unity.render-pipelines.universal/Runtime/UniversalRenderer.cs b/com.unity.render-pipelines.universal/Runtime/UniversalRenderer.cs index e0c8f3e9b65..7a90e8cf2d5 100644 --- a/com.unity.render-pipelines.universal/Runtime/UniversalRenderer.cs +++ b/com.unity.render-pipelines.universal/Runtime/UniversalRenderer.cs @@ -879,7 +879,7 @@ public override void SetupCullingParameters(ref ScriptableCullingParameters cull cullingParameters.conservativeEnclosingSphere = UniversalRenderPipeline.asset.conservativeEnclosingSphere; - cullingParameters.numIterationsEnclosingSphere = UniversalRenderPipeline.asset.numItertionsEnclosingSphere; + cullingParameters.numIterationsEnclosingSphere = UniversalRenderPipeline.asset.numIterationsEnclosingSphere; } /// From a9878e1d0321d960b7c005a7e1fd28e22eae3bbf Mon Sep 17 00:00:00 2001 From: Nigel John Williams Date: Thu, 30 Sep 2021 11:33:32 +0200 Subject: [PATCH 2/3] Added changelog --- com.unity.render-pipelines.universal/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/com.unity.render-pipelines.universal/CHANGELOG.md b/com.unity.render-pipelines.universal/CHANGELOG.md index fd37d46e35c..94c4b2c832b 100644 --- a/com.unity.render-pipelines.universal/CHANGELOG.md +++ b/com.unity.render-pipelines.universal/CHANGELOG.md @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Removed experimental tile deferred code. - VFX: New shadergraph support directly on Universal target. - URP will no longer render via an intermediate texture unless actively required by a Renderer Feature. See the upgrade guide for compatibility options and how assets are upgraded. +- Fixed typo in numIterationsEnclosingSphere api name ### Fixed - Added warning for lit shader detailed abledo, if texture is not linear. [1342011](https://issuetracker.unity3d.com/issues/detail-maps-packed-differently-in-built-in-vs-urp) From b6fc5d8c786637aa6fb3520538eecba6e362da6d Mon Sep 17 00:00:00 2001 From: Nigel John Williams Date: Wed, 6 Oct 2021 19:54:31 +0200 Subject: [PATCH 3/3] Added missing docs --- .../Runtime/Data/UniversalRenderPipelineAsset.cs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/com.unity.render-pipelines.universal/Runtime/Data/UniversalRenderPipelineAsset.cs b/com.unity.render-pipelines.universal/Runtime/Data/UniversalRenderPipelineAsset.cs index 19e07598051..4f87708853c 100644 --- a/com.unity.render-pipelines.universal/Runtime/Data/UniversalRenderPipelineAsset.cs +++ b/com.unity.render-pipelines.universal/Runtime/Data/UniversalRenderPipelineAsset.cs @@ -918,12 +918,19 @@ public bool useAdaptivePerformance set { m_UseAdaptivePerformance = value; } } + /// + /// Set to true to enable a conservative method for calculating the size and position of the minimal enclosing sphere around the frustum cascade corner points for shadow culling. + /// public bool conservativeEnclosingSphere { get { return m_ConservativeEnclosingSphere; } set { m_ConservativeEnclosingSphere = value; } } + /// + /// Set the number of iterations to reduce the cascade culling enlcosing sphere to be closer to the absolute minimun enclosing sphere, but will also require more CPU computation for increasing values. + /// This parameter is used only when conservativeEnclosingSphere is set to true. Default value is 64. + /// public int numIterationsEnclosingSphere { get { return m_NumIterationsEnclosingSphere; }