From 217605237fd2c2347e55d3592f5b4d87b7e9fc69 Mon Sep 17 00:00:00 2001 From: Arttu Peltonen Date: Tue, 19 Oct 2021 10:33:34 +0300 Subject: [PATCH 1/2] Fix reflections-with-smoothness debug mode. --- .../ShaderLibrary/Debug/Debugging3D.hlsl | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/com.unity.render-pipelines.universal/ShaderLibrary/Debug/Debugging3D.hlsl b/com.unity.render-pipelines.universal/ShaderLibrary/Debug/Debugging3D.hlsl index a9df611b011..27e63b8bd9a 100644 --- a/com.unity.render-pipelines.universal/ShaderLibrary/Debug/Debugging3D.hlsl +++ b/com.unity.render-pipelines.universal/ShaderLibrary/Debug/Debugging3D.hlsl @@ -57,18 +57,12 @@ bool UpdateSurfaceAndInputDataForDebug(inout SurfaceData surfaceData, inout Inpu surfaceData.occlusion = 1; surfaceData.clearCoatMask = 0; surfaceData.clearCoatSmoothness = 1; + surfaceData.specular = 1; + surfaceData.metallic = 0; if (_DebugLightingMode == DEBUGLIGHTINGMODE_REFLECTIONS) { - surfaceData.specular = 1; - surfaceData.metallic = 0; surfaceData.smoothness = 1; } - else if (_DebugLightingMode == DEBUGLIGHTINGMODE_REFLECTIONS_WITH_SMOOTHNESS) - { - surfaceData.specular = 0; - surfaceData.metallic = 1; - surfaceData.smoothness = 0; - } changed = true; } From 4e438d8bc8c6b8fa394334026ebbf2d6729872ed Mon Sep 17 00:00:00 2001 From: Arttu Peltonen Date: Mon, 25 Oct 2021 10:55:10 +0300 Subject: [PATCH 2/2] Changelog --- com.unity.render-pipelines.universal/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/com.unity.render-pipelines.universal/CHANGELOG.md b/com.unity.render-pipelines.universal/CHANGELOG.md index 70b7aaf8fe3..a201362ea6d 100644 --- a/com.unity.render-pipelines.universal/CHANGELOG.md +++ b/com.unity.render-pipelines.universal/CHANGELOG.md @@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fix for rendering thumbnails. [case 1348209](https://issuetracker.unity3d.com/issues/preview-of-assets-do-not-show-in-the-project-window) - Fixed a regression bug where XR camera postion can not be modified in beginCameraRendering [case 1365000] - Fixed an issue in where installing the Adaptive Performance package caused errors to the inspector UI [1368161](https://issuetracker.unity3d.com/issues/urp-package-throws-compilation-error-cs1525-when-imported-together-with-adaptive-performance-package) +- Fixed incorrect behavior of Reflections with Smoothness lighting debug mode. [case 1374181] ## [13.1.0] - 2021-09-24 ### Added