From 430217d5bc5830ecaacdbc20a747635ea4064f55 Mon Sep 17 00:00:00 2001 From: Sai Narayan Date: Thu, 7 Oct 2021 17:04:39 -0700 Subject: [PATCH 1/2] fixes to not return category on empty query if child item is available --- com.unity.shadergraph/Editor/Drawing/SearchWindowAdapter.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/com.unity.shadergraph/Editor/Drawing/SearchWindowAdapter.cs b/com.unity.shadergraph/Editor/Drawing/SearchWindowAdapter.cs index f7c789b351d..90812184409 100644 --- a/com.unity.shadergraph/Editor/Drawing/SearchWindowAdapter.cs +++ b/com.unity.shadergraph/Editor/Drawing/SearchWindowAdapter.cs @@ -90,7 +90,7 @@ private int ComputeScoreForMatch(string[] queryTerms, SearcherItem matchItem) public override SearcherItem OnSearchResultsFilter(IEnumerable searchResults, string searchQuery) { if (searchQuery.Length == 0) - return searchResults.FirstOrDefault(); + return GetFirstChildItem(searchResults.FirstOrDefault()); // Sort results by length so that shorter length results are prioritized // prevents entries with short names getting stuck at end of list after entries with longer names when both contain the same word From 19495a90ba70697988b040b6583a8706dccb334a Mon Sep 17 00:00:00 2001 From: Sai Narayan Date: Mon, 25 Oct 2021 16:58:05 -0700 Subject: [PATCH 2/2] added changelog --- com.unity.shadergraph/CHANGELOG.md | 6 ++++++ com.unity.shadergraph/package.json | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/com.unity.shadergraph/CHANGELOG.md b/com.unity.shadergraph/CHANGELOG.md index cbd7ce2f84b..51008ff3f10 100644 --- a/com.unity.shadergraph/CHANGELOG.md +++ b/com.unity.shadergraph/CHANGELOG.md @@ -14,8 +14,14 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ### Changed - Changed the title suffix on old nodes and properties rom "Deprecated" to "Legacy". + - Updated searcher package dependency version to 4.9.1 ### Fixed + - Fixed a usability issue where in some cases searcher would suggest one collapsed category of results that user would have to manually expand anyway + - Fixed bug that causes search results to not be visible sometimes in the searcher window [1366061] + - Fixed bug that causes exceptions to be thrown when using the up/down arrow keys with search list focused [1358016] + - Fixed bug that causes some searcher items to be irreversibly collapsed due to expand icon disappearing on collapsing those items [1366074] + - Fixed bug that caused incorrect search results with non whitespaced queries for nodes with spaces in their name and for subgraphs [1359158] - Fixed Triplanar ShaderGraph node to handle arbitrary input and output coordinate spaces [1346477] (https://issuetracker.unity3d.com/issues/shader-graph-rotating-gameobject-get-material-stretched-when-using-triplanar-node) - Fixed a bug that Parallax Mapping and Parallax Occlusion Mapping nodes don't use the same channel to sample heightmap by adding drop-downs for channel selecting to both of the nodes. [1347270] (https://fogbugz.unity3d.com/f/cases/1347270/) - Fixed errors in the ShaderGraph Transform node [1368082] diff --git a/com.unity.shadergraph/package.json b/com.unity.shadergraph/package.json index aab0aa536e1..00c0123fc63 100644 --- a/com.unity.shadergraph/package.json +++ b/com.unity.shadergraph/package.json @@ -6,7 +6,7 @@ "displayName": "Shader Graph", "dependencies": { "com.unity.render-pipelines.core": "13.1.1", - "com.unity.searcher": "4.8.0" + "com.unity.searcher": "4.9.1" }, "samples": [ {