From bfedfed712f1c3d6e47772ca96a9e97113ce0b83 Mon Sep 17 00:00:00 2001 From: Antoine Lelievre Date: Tue, 26 Oct 2021 19:32:25 +0200 Subject: [PATCH 1/2] Update tooltip --- .../Editor/Lighting/ProbeVolume/ProbeVolumeUI.Drawer.cs | 5 ++++- .../Editor/Lighting/ProbeVolume/ProbeVolumeUI.Skin.cs | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeUI.Drawer.cs b/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeUI.Drawer.cs index f55ffc50552..62d67a3629d 100644 --- a/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeUI.Drawer.cs +++ b/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeUI.Drawer.cs @@ -204,9 +204,12 @@ static void Drawer_VolumeContent(SerializedProbeVolume serialized, Editor owner) serialized.size.vector3Value = tmpClamp; } - EditorGUILayout.PropertyField(serialized.objectLayerMask, Styles.s_ObjectLayerMask); + EditorGUILayout.LabelField("Geometry Settings", EditorStyles.boldLabel); + EditorGUI.indentLevel++; + EditorGUILayout.PropertyField(serialized.objectLayerMask, Styles.s_ObjectLayerMask); EditorGUILayout.PropertyField(serialized.geometryDistanceOffset, Styles.s_GeometryDistanceOffset); + EditorGUI.indentLevel--; } } } diff --git a/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeUI.Skin.cs b/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeUI.Skin.cs index 0dacaaa504c..0b8f466bb61 100644 --- a/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeUI.Skin.cs +++ b/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeUI.Skin.cs @@ -11,8 +11,8 @@ internal static class Styles internal static readonly GUIContent s_OverridesSubdivision = new GUIContent("Override Subdivision Levels", "Whether to override or not the subdivision levels."); internal static readonly GUIContent s_HighestSubdivLevel = new GUIContent("Highest Subdivision Level", "Overrides the highest subdivision level used by the system. This determines how finely a probe volume is subdivided, lower values means larger minimum distance between probes."); internal static readonly GUIContent s_LowestSubdivLevel = new GUIContent("Lowest Subdivision Level", "Overrides the lowest subdivision level used by the system. This determines how coarsely a probe volume is allowed to be subdivided, higher values means smaller maximum distance between probes."); - internal static readonly GUIContent s_ObjectLayerMask = new GUIContent("Object Layer Mask", "Control which layers will be used to select the meshes for the probe placement algorithm."); - internal static readonly GUIContent s_GeometryDistanceOffset = new GUIContent("Geometry Distance Offset", "Affects the minimum distance at which the subdivision system will place probes near the geometry."); + internal static readonly GUIContent s_ObjectLayerMask = new GUIContent("Layer Mask", "Control which layers will be used to select the meshes for the probe placement algorithm."); + internal static readonly GUIContent s_GeometryDistanceOffset = new GUIContent("Probe Placement Distance Offset", "Affects the minimum distance at which the subdivision system will attempt to place probes near the geometry. This value can be useful in situations where the generated probes don't fully cover an object."); internal static readonly string s_ProbeVolumeChangedMessage = "The probe volume has changed since last baking or the data was never baked.\nPlease bake lighting in the lighting panel to update the lighting data."; internal static readonly Color k_GizmoColorBase = new Color32(137, 222, 144, 255); From 14e14ced5b8b1b86c76617a3b82d98850608a3d3 Mon Sep 17 00:00:00 2001 From: Antoine Lelievre Date: Thu, 4 Nov 2021 11:06:36 +0100 Subject: [PATCH 2/2] Update ProbeVolumeUI.Skin.cs --- .../Editor/Lighting/ProbeVolume/ProbeVolumeUI.Skin.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeUI.Skin.cs b/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeUI.Skin.cs index 0b8f466bb61..54224ab9ce9 100644 --- a/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeUI.Skin.cs +++ b/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeUI.Skin.cs @@ -12,7 +12,7 @@ internal static class Styles internal static readonly GUIContent s_HighestSubdivLevel = new GUIContent("Highest Subdivision Level", "Overrides the highest subdivision level used by the system. This determines how finely a probe volume is subdivided, lower values means larger minimum distance between probes."); internal static readonly GUIContent s_LowestSubdivLevel = new GUIContent("Lowest Subdivision Level", "Overrides the lowest subdivision level used by the system. This determines how coarsely a probe volume is allowed to be subdivided, higher values means smaller maximum distance between probes."); internal static readonly GUIContent s_ObjectLayerMask = new GUIContent("Layer Mask", "Control which layers will be used to select the meshes for the probe placement algorithm."); - internal static readonly GUIContent s_GeometryDistanceOffset = new GUIContent("Probe Placement Distance Offset", "Affects the minimum distance at which the subdivision system will attempt to place probes near the geometry. This value can be useful in situations where the generated probes don't fully cover an object."); + internal static readonly GUIContent s_GeometryDistanceOffset = new GUIContent("Probe Placement Distance Offset", "Affects the minimum distance at which the subdivision system will attempts to place probes near the geometry. This value can be useful in situations where the generated probes don't fully cover an object."); internal static readonly string s_ProbeVolumeChangedMessage = "The probe volume has changed since last baking or the data was never baked.\nPlease bake lighting in the lighting panel to update the lighting data."; internal static readonly Color k_GizmoColorBase = new Color32(137, 222, 144, 255);