Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Universal Staging branch #7093

Merged
merged 6 commits into from Feb 18, 2022
Merged

Universal Staging branch #7093

merged 6 commits into from Feb 18, 2022

Conversation

phi-lira
Copy link
Collaborator

@phi-lira phi-lira commented Feb 10, 2022 •
edited

robin-demoor and others added 3 commits February 10, 2022 16:38
@robin-demoor @phi-lira
Initialze RT descriptor for preview camera, case 1393818 (#6798)
039a8f6 
* Initiialze RT descriptor for preview camera case 1393818

* Add Changelog

* Move SetCameraSettings so the descriptor is set in each possible situation

* formatting

* formatting

* Remove empty commandbuffer execute

* Remove reset to buffer A when setting descriptor

Co-authored-by: Felipe Lira <felipedrl@gmail.com>
@thomas-zeng @phi-lira
Fixed Deferred Fog does not work in XR single pass (#6842)
83978c1 
* * Added missing XR macros for deferred fog pass.

* * Updated CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Felipe Lira <felipedrl@gmail.com>
@eh-unity @phi-lira
Add compressed cookie formats to single channel detection. (#7002)
eb32da5 
* Add compressed cookie formats to single channel detection.

* changelog.

Co-authored-by: Felipe Lira <felipedrl@gmail.com>
@phi-lira phi-lira requested a review from a team as a code owner February 10, 2022 16:48
@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@eh-unity @FrancescoC-unity
[URP-220] Add URP backbuffer HDR format options (#6728)
22fd297 
* Add FP16 test case

* Primary render target HDR format.

* Add TODOs for possible HDR format update/syncs with main URP asset.

* Revert "Add FP16 test case"

This reverts commit 7234904.

* Handle user HDR format for postprocessing.

* Don't touch 2D renderer HDR format.

* Adapt native render pass to user hdr format.

* Add FP16 Test case.

* Review comment fixes.

* Remove potential lighting issues from the test case.

* Add changelog.

* Add ref images.

* Fix review issues.

* Rename HDRFormat to HDRPrecision.

* Indent HDR Precision option.

* Changed HDRPrecision to be an additional property.

* Fix code docs.

* Add enum tool tips. Improve tooltips.

* Add missing namespace.

* Fix merge.

* Add filter for mac for APV test (#7091)

Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
@phi-lira phi-lira requested a review from a team as a code owner February 11, 2022 08:14
ernestasKupciunas
ernestasKupciunas approved these changes Feb 14, 2022
View reviewed changes
Copy link

@ernestasKupciunas ernestasKupciunas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs are looking good.
I have triggered this Yamato job, which runs URP Sample scene on multiple platforms and tests the visual correctness: https://yamato.cds.internal.unity3d.com/jobs/1724-reach-qa-graphics-template-urp/tree/master/.yamato%252FAll.yml%2523trunk_Run_All/11624620/job/pipeline

@phi-lira
Copy link
Collaborator Author

All the failures seem related to 3 errors. These seems fixed in master already. Rerunning some tests on 22fd297 to validate.

  • EditorTests.CreateUniversalRendererAssetWithoutErrors
  • editor Test Failure: UnityEngine.Rendering.Utils.Tests.TimedScopeTests.SimpleTimeCheckFromPtr
  • BoatAttack performance test native collection failure.

@phi-lira phi-lira merged commit 8f3fc19 into master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestasKupciunas ernestasKupciunas ernestasKupciunas approved these changes

Assignees
No one assigned
Labels
universal
Projects
None yet
Milestone
No milestone
5 participants
@phi-lira @ernestasKupciunas @robin-demoor @thomas-zeng @eh-unity