Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom pass scaling issues in after post process #7222

Closed

Conversation

alelievr
Copy link
Member

@alelievr alelievr commented Feb 21, 2022

Purpose of this PR

Fix an issue regarding the scaling of texture read from the after-post-process injection point.


Testing status

Tested that we can read the camera main color in a custom pass with the injection point after post-process and tested several dynamic resolution settings and upsampling algorithms and DLSS

https://unity-ci.cds.internal.unity3d.com/job/11824094/dependency-graph

@alelievr alelievr self-assigned this Feb 21, 2022
@alelievr alelievr marked this pull request as ready for review February 21, 2022 13:54
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Feb 21, 2022
Copy link
Contributor

@TomasKiniulis TomasKiniulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Checked that no scaling issues occur when camera is looking directly into the planar probe when fullscreen shader writes color from Custom Color buffer. Tested Custom Pass on all injection points.

@sebastienlagarde
Copy link
Collaborator

replicated on private

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants