Fix AxisControl types without clamps not updating properly #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calling EvaluateMagnitude.
|
@Rene-Damm This function relies on EvaluateMagnitude in order to identify a change in the control. When updating the control frame-by-frame, it leaves this function here: Because the control is either cancelled or the result of EvaluateMagnitude is -1 (so the trigger and action state magnitudes are the same). Not sure this is the right fix. This test uses a second gamepad so that conflict resolution turns on. This axis won't be normalized, so it will be able within a potentially different range. |
(cherry picked from commit a661a1a)
…nto Magnitude-Unclamped-AxisControl # Conflicts: # .yamato/upm-ci.yml
Revert CI Change
|
I suspect the right fix for this is in the action system's disambiguation code, not in |
js-dignitas
added a commit
to js-dignitas/InputSystem
that referenced
this pull request
Jul 5, 2021
* github/develop: CHANGE: Move Unity min version up to 2019.4 LTS (Unity-Technologies#1168). FIX: Stack overflow in SwithCurrentActionMap (case 1232893, Unity-Technologies#1164). FIX: Gravity, LinearAcceleration, and Attitude not initialized on iOS (case 1251382, Unity-Technologies#1160). FIX: Control picker empty when using 'Supported Devices' (case 1254150, Unity-Technologies#1163). NEW: Add concept of 'precompiled layouts' (Unity-Technologies#1156). FIX: Missing HelpURLs (Unity-Technologies#1157). FIX: Actions not triggering with axis controls that have no limits (Unity-Technologies#1128). FIX: Broken CI (Unity-Technologies#1159). FIX: CHANGELOG dates not conforming to ISO 8601 (Unity-Technologies#1141). FIX: No input coming through in UnityTests (Unity-Technologies#1139). FIX: Drag-reordering losing bindings (case 1228000, Unity-Technologies#1150). CHANGE: Added Windows Input tests to ensure Mouse movement works usin… (Unity-Technologies#1080) FIX: Broken CI from NPM server changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue where an AxisControl without a min/max clamp value would only receive the first 'performed' event, and no subsequent events until the action was cancelled. This was because AxisControl.EvaluateMagnitude early outs with -1 and so underlying action systems think that the action has not changed between frames. It feels appropriate that the magnitude of an AxisControl is just the absolute value if there are no other parameters, but I'm not sure if there was a specific reason for it.
This fixes internal bug #1183862