Skip to content

Conversation

@karljj1
Copy link
Collaborator

@karljj1 karljj1 commented Jun 1, 2020

Copy of this PR: #1145
Fixes https://fogbugz.unity3d.com/f/cases/1221223/

Fixes a bug that prevented DualShock controllers from working on tvOS.

I created this PR for @itsneil (neil.skinner) as he does not have permission to push. He will be verifying the fix with QA before we merge.

@karljj1 karljj1 requested a review from Rene-Damm June 1, 2020 13:24
@Rene-Damm
Copy link
Contributor

Seems like the existing test in iosTests would have failed on tvOS and caught the error. Wondering... can we set up a test where we simply cycle the project through all platforms and run the tests in the editor on each? Not the same as running on the device but it should already be able to catch a number of errors that otherwise go unnoticed.

# Conflicts:
#	Packages/com.unity.inputsystem/CHANGELOG.md
@karljj1 karljj1 merged commit 3ec1c52 into develop Jul 2, 2020
@karljj1 karljj1 deleted the tvos/fix-dualshock-input branch July 2, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants