FIX: Memory corruption in InputEventTrace (case 1262496). #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karljj1
reviewed
Aug 5, 2020
| @@ -13,6 +13,15 @@ public static int AlignToMultipleOf(this int number, int alignment) | |||
| return number + alignment - remainder; | |||
| } | |||
|
|
|||
| public static long AlignToMultipleOf(this long number, long alignment) | |||
There was a problem hiding this comment.
Should we add a test just for this function?
There was a problem hiding this comment.
I'll go add something in the next PRs.
karljj1
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 1262496 (internal).
Was a stupid thing where I changed the meaning of
capacityto be in line with how it is used elsewhere in .NET but then didn't correctly update all the code that depended on the previous meaning.