Skip to content

Conversation

@graham-huws
Copy link
Collaborator

@graham-huws graham-huws commented Jan 29, 2024

Description

The "Listen" button would sometimes be listening to the wrong type of input. This was due to part of the code assuming that the selected item was an Action, when it would be a Binding. ISX-1832

Changes made

In GetSelectedAction, we now return the relevant "parent" action if the user had a Binding selected.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@graham-huws graham-huws changed the title FIX: Return a valid input action from GetSelectedAction when a bindin… FIX: "Listen" button listening for wrong type (ISX-1832). Jan 29, 2024
@graham-huws graham-huws force-pushed the ISX-1832-listen-button-wrong-type branch from 3534746 to 3ba76ec Compare January 29, 2024 22:03
@graham-huws graham-huws force-pushed the ISX-1832-listen-button-wrong-type branch from 3ba76ec to 606b5b5 Compare January 30, 2024 10:32
@graham-huws graham-huws marked this pull request as ready for review January 30, 2024 11:13
Copy link
Collaborator

@ritamerkl ritamerkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Pauliusd01 Pauliusd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked listen button functionality with different types of bindings in ProjectWideActions/CustomInputActions

@graham-huws graham-huws merged commit 319f404 into develop Jan 30, 2024
@graham-huws graham-huws deleted the ISX-1832-listen-button-wrong-type branch January 30, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants