-
Notifications
You must be signed in to change notification settings - Fork 329
DOCS: Updated InputValue documentation #2065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated InputValue documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving it since I think its a good improvement, but added a bunch of minor comments which @duckets might also provide guidance regarding
Packages/com.unity.inputsystem/InputSystem/Plugins/PlayerInput/InputValue.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Plugins/PlayerInput/InputValue.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Plugins/PlayerInput/InputValue.cs
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Plugins/PlayerInput/InputValue.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Plugins/PlayerInput/InputValue.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Plugins/PlayerInput/InputValue.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Plugins/PlayerInput/InputValue.cs
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Plugins/PlayerInput/InputValue.cs
Outdated
Show resolved
Hide resolved
|
@lyndon-unity PR title is not conforming. Prefix by "DOCS: " |
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather minor proposals, approving
Packages/com.unity.inputsystem/InputSystem/Plugins/PlayerInput/InputValue.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Plugins/PlayerInput/InputValue.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Plugins/PlayerInput/InputValue.cs
Show resolved
Hide resolved
|
Seems to be CI failures: PVP-150-1: UnityEngine.InputSystem.InputValue: TValue Get(): in block context (only allowed in top-level context) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice to see CI problems fixed


Description
Updated InputValue API documentation
Testing status & QA
Reviewed generated docs using the DocTools package and checked the validation results
Overall Product Risks
Comments to reviewers
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: