From e69a4a2d73bb807009560b999f11bbbe7733e802 Mon Sep 17 00:00:00 2001 From: James McGill Date: Thu, 13 Mar 2025 12:31:31 +0100 Subject: [PATCH 1/2] FIX: Prevent errors on certain platforms --- .../InputSystem/Editor/InputSystemPluginControl.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/Packages/com.unity.inputsystem/InputSystem/Editor/InputSystemPluginControl.cs b/Packages/com.unity.inputsystem/InputSystem/Editor/InputSystemPluginControl.cs index f6f284b4e5..30ae8bee3e 100644 --- a/Packages/com.unity.inputsystem/InputSystem/Editor/InputSystemPluginControl.cs +++ b/Packages/com.unity.inputsystem/InputSystem/Editor/InputSystemPluginControl.cs @@ -43,6 +43,7 @@ private static void CheckForExtension() #if UNITY_2023_3_OR_NEWER BuildTarget.VisionOS, #endif + (BuildTarget)49, BuildTarget.NoTarget }; From d4a27f9c2f405c25bd0a5d15903db9dd0749d54e Mon Sep 17 00:00:00 2001 From: James McGill Date: Tue, 18 Mar 2025 10:56:03 +0100 Subject: [PATCH 2/2] fix for failing test due to float accuracy --- .../InputLatencyCalculatorTests.cs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Assets/Tests/InputSystem.Editor/InputLatencyCalculatorTests.cs b/Assets/Tests/InputSystem.Editor/InputLatencyCalculatorTests.cs index e8a099be37..0f7cff1244 100644 --- a/Assets/Tests/InputSystem.Editor/InputLatencyCalculatorTests.cs +++ b/Assets/Tests/InputSystem.Editor/InputLatencyCalculatorTests.cs @@ -62,9 +62,9 @@ public void MetricsShouldOnlyUpdate_WhenPeriodHasElapsed() m_Sut = new InputLatencyCalculator(0.0); GivenSamples(0.5, 0.3, 0.4, 0.5); m_Sut.Update(1.0); - Assert.That(m_Sut.averageLatencySeconds, Is.EqualTo(0.1f)); - Assert.That(m_Sut.minLatencySeconds, Is.EqualTo(0.0f)); - Assert.That(m_Sut.maxLatencySeconds, Is.EqualTo(0.2f)); + Assert.That(m_Sut.averageLatencySeconds, Is.EqualTo(0.1f).Within(0.00001)); + Assert.That(m_Sut.minLatencySeconds, Is.EqualTo(0.0f).Within(0.00001)); + Assert.That(m_Sut.maxLatencySeconds, Is.EqualTo(0.2f).Within(0.00001)); } [Test] @@ -73,9 +73,9 @@ public void MetricShouldNotBeAffected_WhenMoreThanAPeriodHasElapsed() m_Sut = new InputLatencyCalculator(0.0); GivenSamples(0.5, 0.3, 0.4, 0.5); m_Sut.Update(2.0); - Assert.That(m_Sut.averageLatencySeconds, Is.EqualTo(0.1f)); - Assert.That(m_Sut.minLatencySeconds, Is.EqualTo(0.0f)); - Assert.That(m_Sut.maxLatencySeconds, Is.EqualTo(0.2f)); + Assert.That(m_Sut.averageLatencySeconds, Is.EqualTo(0.1f).Within(0.00001)); + Assert.That(m_Sut.minLatencySeconds, Is.EqualTo(0.0f).Within(0.00001)); + Assert.That(m_Sut.maxLatencySeconds, Is.EqualTo(0.2f).Within(0.00001)); } [Test]