From bc5d24422f15ba2ec65429ab8b0d427f6f326e49 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ha=CC=8Akan=20Sidenvall?= <hakan.sidenvall@unity3d.com>
Date: Fri, 23 May 2025 15:03:04 +0200
Subject: [PATCH] Attempt to fix test instabilities. Added a check dirty
 condition required on macOS otherwise failing locally.

---
 Assets/Tests/InputSystem.Editor/InputActionsEditorTests.cs | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/Assets/Tests/InputSystem.Editor/InputActionsEditorTests.cs b/Assets/Tests/InputSystem.Editor/InputActionsEditorTests.cs
index da0e3b9d73..e50d4f82fe 100644
--- a/Assets/Tests/InputSystem.Editor/InputActionsEditorTests.cs
+++ b/Assets/Tests/InputSystem.Editor/InputActionsEditorTests.cs
@@ -74,7 +74,6 @@ IEnumerator WaitForActionRename(int index, bool isActive, double timeoutSecs = 5
     #endregion
 
     [Test]
-    [Ignore("Instability, see ISXB-1284")]
     public void CanListActionMaps()
     {
         var actionMapsContainer = m_Window.rootVisualElement.Q("action-maps-container");
@@ -88,7 +87,6 @@ public void CanListActionMaps()
     }
 
     [UnityTest]
-    [Ignore("Instability, see ISXB-1284")]
     public IEnumerator CanCreateActionMap()
     {
         var button = m_Window.rootVisualElement.Q<Button>("add-new-action-map-button");
@@ -117,7 +115,6 @@ public IEnumerator CanCreateActionMap()
     }
 
     [UnityTest]
-    [Ignore("Instability, see ISXB-1284")]
     public IEnumerator CanRenameActionMap()
     {
         var actionMapsContainer = m_Window.rootVisualElement.Q("action-maps-container");
@@ -166,7 +163,6 @@ public IEnumerator CanRenameActionMap()
     }
 
     [UnityTest]
-    [Ignore("Instability, see ISXB-1284")]
     public IEnumerator CanDeleteActionMap()
     {
         var actionMapsContainer = m_Window.rootVisualElement.Q("action-maps-container");
@@ -195,7 +191,6 @@ public IEnumerator CanDeleteActionMap()
     }
 
     [UnityTest]
-    [Ignore("Instability, see ISXB-1284")]
     public IEnumerator CanRenameAction()
     {
         var actionContainer = m_Window.rootVisualElement.Q("actions-container");
@@ -215,6 +210,8 @@ public IEnumerator CanRenameAction()
 
         // Click twice to start the rename
         SimulateClickOn(actionItem[1]);
+        yield return WaitForNotDirty();
+
         // If the item is already focused, don't click again
         if (!actionItem[1].IsFocused)
         {