New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for the Realtime raytracing support #1985

Merged
merged 3 commits into from Oct 12, 2018

Conversation

Projects
None yet
3 participants
@anisunity
Copy link
Contributor

anisunity commented Sep 14, 2018

Initial commit that adds support for the DXR raytracing in DHRP

@anisunity anisunity self-assigned this Sep 14, 2018

@anisunity anisunity requested a review from sebastienlagarde Sep 14, 2018

@anisunity

This comment has been minimized.

Copy link
Contributor

anisunity commented Sep 14, 2018

For the moment we cannot merge this PR because it depends on code that is not merge on trunk yet.

@anisunity anisunity force-pushed the Raytracing_Initial branch from 4552c5a to fe6bafa Sep 25, 2018

@anisunity

This comment has been minimized.

Copy link
Contributor

anisunity commented Sep 25, 2018

Now, we can merge this PR safetly after katana tests are OK

@anisunity anisunity force-pushed the Raytracing_Initial branch 2 times, most recently from 04c73a2 to fc5ee49 Sep 26, 2018

@anisunity anisunity force-pushed the Raytracing_Initial branch 2 times, most recently from 4011b62 to c70b779 Oct 8, 2018

@anisunity anisunity force-pushed the Raytracing_Initial branch from 7665b2c to 9264b38 Oct 10, 2018

@anisunity anisunity requested a review from JulienIgnace-Unity Oct 12, 2018

const int currentVersion = 1;

#if ENABLE_RAYTRACING
// Culling mask that defines the layers that this acceleration structure

This comment has been minimized.

@JulienIgnace-Unity

JulienIgnace-Unity Oct 12, 2018

Collaborator

Missing end of comment?

public List<HDRayTracingGraph> referenceGraphs = new List<HDRayTracingGraph>();
}

Dictionary<int, HDRayTracingSubScene> m_subScenes = null;

This comment has been minimized.

@JulienIgnace-Unity

JulienIgnace-Unity Oct 12, 2018

Collaborator

Members should be m_UpperCase

@JulienIgnace-Unity
Copy link
Collaborator

JulienIgnace-Unity left a comment

Some minors formatting changes

{
[DisallowMultipleComponent, ExecuteInEditMode]
[RequireComponent(typeof(Camera))]
public class HDRayTracingGraph : MonoBehaviour

This comment has been minimized.

@sebastienlagarde

sebastienlagarde Oct 12, 2018

Collaborator

Rename HDRayTracingGraph => HDRayTracingFilter

@sebastienlagarde sebastienlagarde merged commit 7612139 into master Oct 12, 2018

@sebastienlagarde sebastienlagarde deleted the Raytracing_Initial branch Oct 12, 2018

sebastienlagarde added a commit that referenced this pull request Oct 12, 2018

Initial commit for the Realtime raytracing support (#1985)
* Initial commit for the Realtime raytracing support

* Making the Raytracing support work with adding a define in the project (for the moment)

* review corrections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment