Skip to content

AIRO-1211: Pick-and-Place Updates #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 1, 2021
Merged

AIRO-1211: Pick-and-Place Updates #319

merged 9 commits into from
Oct 1, 2021

Conversation

@at669
Copy link
Contributor

@at669 at669 commented Sep 27, 2021 •
edited
Loading

Proposed change(s)

  • Niryo joint position message -> list
  • Don't convert to radians and back
  • Remove niryo server_endpoint (use default)
  • Updates for deprecated APIs
  • Style fixes

Note: will not be ready for merge until next Endpoint and Connector releases

TODOs before merge:

  • Update package manifest to point to new tag
  • Update endpoint submodule to correct tag

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

Types of change(s)

  • Bug fix

Testing and Verification

Ran unit tests, ran demo, parts 2 and 3 launch files.

Test Configuration:

  • Unity Version: 2020.3.11f
  • Unity machine OS + version: MacOS 10.15.7
  • ROS machine OS + version: Ubuntu 18.04, ROS Melodic
  • ROS–Unity communication: Docker

Checklist

  • Ensured this PR is up-to-date with the dev branch
  • Created this PR to target the dev branch
  • Followed the style guidelines as described in the Contribution Guidelines
  • Updated the Changelog and described changes in the Unreleased section
  • Updated the documentation as appropriate

@at669 at669 changed the title [WIP] AIRO-1211: Pick-and-Place Updates AIRO-1211: Pick-and-Place Updates Sep 27, 2021
peifeng-unity
peifeng-unity reviewed Sep 28, 2021
View reviewed changes
@LaurieCheers-unity LaurieCheers-unity marked this pull request as ready for review October 1, 2021 20:38
at669
at669 commented Oct 1, 2021
View reviewed changes
tutorials/ros_unity_integration/ros_docker/Dockerfile

RUN git clone https://github.com/Unity-Technologies/ROS-TCP-Endpoint $ROS_WORKSPACE/src/ros_tcp_endpoint -b v0.5.0

RUN git clone https://github.com/Unity-Technologies/ROS-TCP-Endpoint $ROS_WORKSPACE/src/ros_tcp_endpoint -b dev
Copy link
Contributor Author

@at669 at669 Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LaurieCheers-unity this also should be updated, i believe?

Copy link
Contributor

@LaurieCheers-unity LaurieCheers-unity Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Unity-Technologies/Unity-Robotics-Hub/pull/322/files

@LaurieCheers-unity LaurieCheers-unity merged commit 67c6461 into dev Oct 1, 2021
@at669 at669 deleted the amanda/pick-and-place-updates branch October 11, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdiao sdiao Awaiting requested review from sdiao

2 more reviewers

@peifeng-unity peifeng-unity peifeng-unity left review comments

@LaurieCheers-unity LaurieCheers-unity LaurieCheers-unity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@at669 @sdiao @peifeng-unity @LaurieCheers-unity