AIRO-1420 add jira-link check #328
Conversation
peifeng-unity
force-pushed
the
add-jira-link-checker
branch
from
1b9d4a8 to
fcfeea1
Compare
peifeng-unity
requested review from
a team,
LaurieCheers-unity,
at669,
hyounesy,
mrpropellers,
sdiao and
vidurvij-Unity
.github/workflows/jira-link.yaml
Outdated
| on: | ||
| pull_request: | ||
| types: [opened, edited, reopened, synchronize, ready_for_review, review_requested] | ||
| branches: |
There was a problem hiding this comment.
is this for merging into main or dev? I'm not sure if you really need line 5-8.
on: pull_request: should be sufficient to run on all pull requests. what do you think?
There was a problem hiding this comment.
Oh, good question! The types enables the action to run when we change the title after the pull request is open. The default types are open, synchronize, and reopen. We probably need to add edited to trigger the workflow when the PR's title is edited.
For the branches, I am not sure. Do you think we want to check for the PRs that are not merging into our dev or main branches as well?
There was a problem hiding this comment.
oh i see. then we can keep the types.
Yes, even for PRs that are not merging into dev/main branch, it is still good to check the jira link. It also reduces complexity, the jira link check just runs on all pull requests.
There was a problem hiding this comment.
Okay, sure. Just removed the branch part :)
Proposed change(s)
Require a PR to link to an internal JIRA ticket
Types of change(s)
Checklist
devbranchdevbranchOther comments