Skip to content

LODs, 3 VFX, Lighting and post-processing #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 9, 2024
Merged

LODs, 3 VFX, Lighting and post-processing #204

merged 6 commits into from
Aug 9, 2024

Conversation

@VladNeykov
Copy link
Contributor

@VladNeykov VladNeykov commented Aug 6, 2024

Description

Implemented:

  • LODs for Wooden Chairs, Torches, Trees, and Rocks
  • VFX for breaking pottery and wooden crates, and VFX for spawning of players
  • Baked lightmaps and added post processing to the TownMarket_Test_ScenarioWeek level
  • Increased max lights per object on the URP asset to 8 (please feel free to revert if it's not desirable)

For more info, please view this doc.

@VladNeykov VladNeykov requested a review from a team as a code owner August 6, 2024 16:05
@unity-cla-assistant
Copy link

unity-cla-assistant commented Aug 6, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

fernando-cortez
fernando-cortez approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving, but I got a lot of generated warnings about missing LOD meshes on certain prefabs.

I also notice the FX prefabs were added at the end of the scene hierarchy for testing. We could remove those and I think I spotted a few floating rocks.

Let's have @Elfi0Kuhndorf also take a look at this PR when she's back.

Warnings:
Sub Graph at Assets/Shaders/SubGraphs/ToonLightingModel.shadersubgraph has 5 warning(s), the first is: There is a newer version of this node available. Inspect node for details.

Sub Graph at Assets/Shaders/SubGraphs/AdditionalLights.shadersubgraph has 2 warning(s), the first is: There is a newer version of this node available. Inspect node for details.

Sub Graph at Assets/Shaders/SubGraphs/AdditionalLightsToon.shadersubgraph has 1 warning(s), the first is: There is a newer version of this node available. Inspect node for details.

Sub Graph at Assets/Shaders/SubGraphs/WindAddon.shadersubgraph has 1 warning(s), the first is: There is a newer version of this node available. Inspect node for details.

Warning in Graph at Assets/Shaders/Glass.shadergraph on line -1: Ignoring duplicate keyword line 'multi_compile _ LIGHTMAP_ON'

Shader Graph at Assets/Shaders/Toon_Shaking.shadergraph has 1 warning(s), the first is: There is a newer version of this node available. Inspect node for details.

Warning in Graph at Assets/Shaders/Water_Rivers.shadergraph on line -1: Ignoring duplicate keyword line 'multi_compile _ LIGHTMAP_ON'

Warning in Graph at Assets/Shaders/Water_Sea.shadergraph on line -1: Ignoring duplicate keyword line 'multi_compile _ LIGHTMAP_ON'

File 'BigRock_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'Tree2_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'Statue_Mesh_LOD3' has inconsistent LOD naming (_LOD3 found but no _LOD2).

File 'Statue_Mesh_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'BigRock4_low_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'Tree2_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'Tree_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'BigRock4_low_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'BigRock2_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'WoodenChair_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'Torch_low_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'Tree_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'BigRock3_low_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'Tree3_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'BigRock3_low_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

A polygon of Mesh 'RumRumRamsey' in Assets/Art/Props/Statue/Statue_Mesh.fbx is self-intersecting and has been discarded.

File 'Torch_low_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'BigRock2_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'BigRock_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'Tree3_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'Statue_Mesh_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'BigRock_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'Tree2_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'Statue_Mesh_LOD3' has inconsistent LOD naming (_LOD3 found but no _LOD2).

File 'Statue_Mesh_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'BigRock4_low_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'Tree2_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'Tree_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'BigRock4_low_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'BigRock2_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'Torch_low_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'Tree_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'BigRock3_low_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'Tree3_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'BigRock3_low_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'Torch_low_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'BigRock2_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'BigRock_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

File 'Tree3_LOD2' has inconsistent LOD naming (_LOD2 found but no _LOD1).

File 'Statue_Mesh_LOD1' has inconsistent LOD naming (_LOD1 found but no _LOD0).

@VladNeykov
Copy link
Contributor Author

VladNeykov commented Aug 7, 2024 •
edited
Loading

Hi @fernando-cortez ,
Nice catch, the LOD warnings appear only on the first load so I missed that. The issue is that Unity prefers LODs to be exported as sub-objects of the same FBX, and I just added LOD1 and LOD2, but didn't change the original asset. I'll re-export all the LODs as new FBX with sub-meshes. This means that someone should confirm if the original meshes are still needed and remove them.

I also notice the FX prefabs were added at the end of the scene hierarchy for testing.

Yup, Elfi asked me to create a temp new scene so I left them there for visibility, but happy to remove them if we want to end up using this scene.

For the floating rock, looks like some of the rock prefabs had offsets, I'll fix this along the LOD fixes.

@VladNeykov
Copy link
Contributor Author

VladNeykov commented Aug 7, 2024

Hi @fernando-cortez , all the LOD warnings should be fixed now (that also fixed the floating rock).
The VFX are also removed from the scene and lighting is re-baked.

I hadn't done any shader work, but I also cleared up the shader warnings you mentioned.
Should be all good, thanks for catching these :)

@fernando-cortez
Copy link
Contributor

fernando-cortez commented Aug 7, 2024

Hi @fernando-cortez , all the LOD warnings should be fixed now (that also fixed the floating rock). The VFX are also removed from the scene and lighting is re-baked.

I hadn't done any shader work, but I also cleared up the shader warnings you mentioned. Should be all good, thanks for catching these :)

Awesome, thanks for handling those shader warnings! Yeah the warnings related to this PR are now not showing up anymore. Good to go for me 😀

@Elfi0Kuhndorf
Copy link
Contributor

Elfi0Kuhndorf commented Aug 8, 2024

Looks good to me! It is awesome to see the LODs and VFX working.
One thing I just noticed is that opening the scene takes over 1 minute. Is that to be expected?

Elfi0Kuhndorf
Elfi0Kuhndorf approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Elfi0Kuhndorf Elfi0Kuhndorf merged commit 780fa6b into feat/DistributedAuthoritySample-blockout Aug 9, 2024
@Elfi0Kuhndorf Elfi0Kuhndorf deleted the feat/DistributedAuthoritySample-blockout-art-tweaks branch August 9, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@Elfi0Kuhndorf Elfi0Kuhndorf Elfi0Kuhndorf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@VladNeykov @unity-cla-assistant @fernando-cortez @Elfi0Kuhndorf