Setting all NetworkObjects to invisible causes BufferOverflow error

[vikpek]

Describe the bug
When returning false for all CheckObjectVisibility checks on all NetworkObjects a OverflowException: Could not deserialize SceneObject: Out of buffer space. error occurs.

To Reproduce
Steps to reproduce the behavior:

1. Clone https://github.com/Twin-Drums/MLAPI.Testing.Public
2. Switch to the branch buffer-overflow-report (the branch contains a clean new Netcode 1.0.0 project - and is not upgraded from a MLAPI project)
3. Open MLAPI.Testing.Public and MLAPI.Testing.Public.Hardcopy
4. Open the scene Server in one and Client in the other project
5. Press play in the server scene, wait until it started and then press play in the client scene
6. Check the client console for Out of buffer space. error

Actual outcome
Client throws a OverflowException: Could not deserialize SceneObject: Out of buffer space. error (see screenshot below).

Expected outcome
No error should appear only because all NetworkObjects are invisible.

Screenshots

Environment:

• OS: Windows 10
• Unity Version: 2020.3.22f1
• Netcode Version: 1.0.0-pre.3

Additional context
Changing the return value to true in NetworkVisibilityObject in line 30: bool HandleCheckObjectVisibility(ulong clientId) => false; will make the error disappear (and also spawn the objects on the client).

[LukeStampfli]

The linked repo project looks like it was initially on the 0.1.0 version. Did this work with the 0.1.0 version and broke now when upgrading to the 1.0.0-pre version?

[vikpek]

Appologies for the confusing setup: The branch buffer-overflow-report is a clean and new setup showing the issue. We just reused the existing public repository which was used for a previous bug report - so no MLAPI upgrade here.

I added a comment about this to the bug description

[ezoray]

This still appears to be an issue, I'll created a bug report, 1403113.

[vikpek]

Still appears with 1.0.0-pre.5.
For reproduction you can follow the upper guidelines just check out the tag failed-verification-1445 instead

[LukeStampfli]

I don't think this has been backported from develop to the 1.0.0-pre.5 release. So it will be in a future release.

[mraue]

This is currently one of the blockers which prevents us from updating to 1.0.0 (from 0.1.0). It would be greatly appreciated if this issue would get some <3. Thanks.