Remote backfill bug #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice Catch! Posting to hopefully grab more attention and integrate this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a nasty bug where a player can be removed during the time where you are fetching the remote backfill ticket.
If the result is assigned to m_LocalBackfillTicket without checking if the data became dirty during the task, then your server will be in an invalid state until it shuts down.
Strangely, if the backfill ticket says that a particular userId is on the backfill ticket, that same userId will be placed in a different match should they queue again, instead of being placed on the same server again. This can lead to a user causing many or ALL servers to be allocated by their userId. This feels like a bug with the matchmaker itself as IMO a user who is already part of a backfill ticket should be assigned to the same match they're "already in", instead of allocating new servers for that player. Alternatively, the matchmaker should update the ticket to reflect the reality of the situation and let the individual server decide whether to kick the player out if they are truly currently in 2 matches.