From dafc738c0935e9b3583e8ddb9ff2c41de8248d48 Mon Sep 17 00:00:00 2001 From: Chris Elion Date: Fri, 22 Nov 2019 11:31:41 -0800 Subject: [PATCH 1/2] add options to set version on files --- utils/validate_versions.py | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/utils/validate_versions.py b/utils/validate_versions.py index c1e6d8acd3..ddd8fba08f 100755 --- a/utils/validate_versions.py +++ b/utils/validate_versions.py @@ -3,6 +3,7 @@ import os import sys from typing import Dict +import argparse VERSION_LINE_START = "__version__ = " @@ -37,7 +38,23 @@ def check_versions() -> bool: return True +def set_version(new_version: str) -> None: + new_contents = f'{VERSION_LINE_START}"{new_version}"\n' + for directory in DIRECTORIES: + path = os.path.join(directory, "__init__.py") + print(f"Setting {path} to version {new_version}") + with open(path, "w") as f: + f.write(new_contents) + + if __name__ == "__main__": - ok = check_versions() - return_code = 0 if ok else 1 - sys.exit(return_code) + parser = argparse.ArgumentParser() + parser.add_argument("--new-version", default=None) + args = parser.parse_args() + if args.new_version: + print(f"Updating to verison {args.new_version}") + set_version(args.new_version) + else: + ok = check_versions() + return_code = 0 if ok else 1 + sys.exit(return_code) From 0bdda94a435c18264bed9b8014ad8846ce5bef15 Mon Sep 17 00:00:00 2001 From: Chris Elion Date: Fri, 22 Nov 2019 11:47:40 -0800 Subject: [PATCH 2/2] fix precommit --- .pre-commit-config.yaml | 2 +- utils/validate_versions.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 72ac56a656..7f77c2d7f9 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -97,4 +97,4 @@ repos: name: validate library versions language: script entry: utils/validate_versions.py - files: ".*/setup.py" + files: ".*/__init__.py" diff --git a/utils/validate_versions.py b/utils/validate_versions.py index ddd8fba08f..77787d60e5 100755 --- a/utils/validate_versions.py +++ b/utils/validate_versions.py @@ -50,6 +50,8 @@ def set_version(new_version: str) -> None: if __name__ == "__main__": parser = argparse.ArgumentParser() parser.add_argument("--new-version", default=None) + # unused, but allows precommit to pass filenames + parser.add_argument("files", nargs="*") args = parser.parse_args() if args.new_version: print(f"Updating to verison {args.new_version}")