This repository was archived by the owner on Jan 9, 2023. It is now read-only.
Add statsd instrumentation #11
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some metrics as to track the throughput, hit-rates and command usage.
I'm not terribly familiar with the underlying protocol and general behaviour of the system, but I am looking to improve performance of our cache server. We have talked about several possible bottlenecks (disk, network, Node.js) but to find out we need some measurements...
It's using the DogStatsD protocol, which is basically statsd with tags in it. Primarily supported by Datadog and the Prometheus statsd exporter.
There are two new options,
--statsd-host [hostname]which set the host to send traffic to and--statsd-tags [key:val, ...]which adds extra tags for the whole server (if ex. having one server per game/office/...)I'll be happy to incorporate any feedback you may have.